Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Aug 8, 2025

Replaced the Type Hints which were either invalid or imported from Core -- to using SDK


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Replaced the Type Hints which were either invalid or imported from Core -- to using SDK
@potiuk
Copy link
Member

potiuk commented Aug 10, 2025

5 approvals ! ... 1 merge :)

@potiuk potiuk merged commit 1ed7062 into apache:main Aug 10, 2025
77 checks passed
@Dev-iL
Copy link
Collaborator

Dev-iL commented Aug 10, 2025

I think these changes are related to the below issues reported on CI:

airflow-core/src/airflow/serialization/serialized_objects.py:1300: error: Argument 1 to "get_link" of "BaseOperatorLink" has incompatible type "SerializedBaseOperator"; expected "BaseOperator" 
[arg-type]
            return link.get_link(self.unmap(None), ti_key=ti.key)
                                 ^~~~~~~~~~~~~~~~

airflow-core/src/airflow/models/mappedoperator.py:168: error: Argument 1 to "get_link" of "BaseOperatorLink" has incompatible type "MappedOperator"; expected "BaseOperator"  [arg-type]
            return link.get_link(self, ti_key=ti.key)

@amoghrajesh
Copy link
Contributor

@Dev-iL yep it seems to be related, I am on it

potiuk added a commit to potiuk/airflow that referenced this pull request Aug 10, 2025
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Aug 15, 2025
Replaced the Type Hints which were either invalid or imported from Core -- to using SDK
@kaxil kaxil deleted the fix-typehints branch December 31, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants