Unify error handling when connection is not found in aws hook #54299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon
Contributor
Author
|
CC @ramitkataria I went ahead and made this change as we discussed last, can I please get a review? |
Member
Nice! |
potiuk
approved these changes
Aug 10, 2025
ramitkataria
approved these changes
Aug 11, 2025
Contributor
ramitkataria
left a comment
ramitkataria
left a comment
There was a problem hiding this comment.
Just 1 nit but looks good to me. Thanks for the PR!
ramitkataria
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 13, 2025
After apache#54299, there was a bit of except handling left over that appears to be redundant. It looks functionally equivalent to not having the additional handling.
potiuk
pushed a commit
that referenced
this pull request
Aug 15, 2025
After #54299, there was a bit of except handling left over that appears to be redundant. It looks functionally equivalent to not having the additional handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The current code checks for two different exception types when handling connection not found errors:
AirflowNotFoundException(from core)AirflowRuntimeErrorwithErrorType.CONNECTION_NOT_FOUND(from Task SDK)However,
self.get_connection()in hooks consistently raisesAirflowNotFoundExceptionregardless of Airflow version. The SDK specificAirflowRuntimeErroris only raised in direct Task SDK API calls, not through the hook'sget_connectionmethod.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.