Fix handling of dark icons for plugins in nav #54305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
requested review from
bbovenzi,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
jscheffl
force-pushed
the
bugfix/fix-handling-of-dark-plugin-icons-in-nav
branch
from
6c2a8dd to
aa8245b
Compare
guan404ming
approved these changes
Aug 10, 2025
Member
guan404ming
left a comment
guan404ming
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the update!
guan404ming
approved these changes
Aug 10, 2025
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Aug 15, 2025
* Fix handling of dark icons for plugins in nav * Review feedback * Review feedback v2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in the nav the new dark mode icons were not applied. When implementing #53563 I saw that dark mode did not consider icons.
This PR fixes the handling also in dark mode.
Light mode:
Dark mode:
