Add optional SQLA logging/diagnostics #54315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Fix several deprecated imports from the task sdk. - Fix `pymysql` typo in test_collation. - Add missing test case for the `mysql+pymysql` connector. - Simplify the MySQL container health check.
Dev-iL
requested review from
XD-DENG,
amoghrajesh,
ashb,
gopidesupavan,
kaxil and
potiuk
as code owners
potiuk
approved these changes
Aug 10, 2025
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Aug 15, 2025
Also: - Fix several deprecated imports from the task sdk. - Fix `pymysql` typo in test_collation. - Add missing test case for the `mysql+pymysql` connector. - Simplify the MySQL container health check.
Member
|
@potiuk Please don't merge mixed things like this -- it makes backporting just one bit trickier. Specifically the "Fix several deprecated imports from the task sdk." in addition to the SQLA logging changes in one PR makes the release manager's life difficult. |
Member
|
Sure. My bad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
pymysqltypo in test_collation.mysql+pymysqlconnector.Split from #52233
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.