Initialize custom variables before running db-reset #54324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before that change, when you set custom variables or intialization in airflow-breeze-config, the initialization was kind of wrongly done. a) in case of regular breeze command, it was done AFTER db-reset b) when start-airflow was done, the initialization was done during the start-airflow - separately - which was kinda strangely duplicated This change unifies it - the initialization of custom variables and scripts happens before we run db-reset or check if we should start airflow.
boring-cyborg
bot
added
area:dev-tools
backport-to-v3-1-test
Contributor
|
Thanks a lot @potiuk . One more follow-up question. Since I am also testing for the provider release. When running |
aritra24
approved these changes
Aug 10, 2025
Collaborator
aritra24
left a comment
aritra24
left a comment
There was a problem hiding this comment.
Hmmmm, I think it makes sense. 🤔
eladkal
approved these changes
Aug 10, 2025
gopidesupavan
approved these changes
Aug 10, 2025
Member
|
ah make sense :) |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 10, 2025
Before that change, when you set custom variables or intialization in airflow-breeze-config, the initialization was kind of wrongly done. a) in case of regular breeze command, it was done AFTER db-reset b) when start-airflow was done, the initialization was done during the start-airflow - separately - which was kinda strangely duplicated This change unifies it - the initialization of custom variables and scripts happens before we run db-reset or check if we should start airflow. (cherry picked from commit 9334484) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Backport successfully created: v3-0-test
|
github-actions bot
pushed a commit
to astronomer/airflow
that referenced
this pull request
Aug 10, 2025
…he#54324) Before that change, when you set custom variables or intialization in airflow-breeze-config, the initialization was kind of wrongly done. a) in case of regular breeze command, it was done AFTER db-reset b) when start-airflow was done, the initialization was done during the start-airflow - separately - which was kinda strangely duplicated This change unifies it - the initialization of custom variables and scripts happens before we run db-reset or check if we should start airflow. (cherry picked from commit 9334484) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 10, 2025
…he#54324) Before that change, when you set custom variables or intialization in airflow-breeze-config, the initialization was kind of wrongly done. a) in case of regular breeze command, it was done AFTER db-reset b) when start-airflow was done, the initialization was done during the start-airflow - separately - which was kinda strangely duplicated This change unifies it - the initialization of custom variables and scripts happens before we run db-reset or check if we should start airflow. (cherry picked from commit 9334484) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk
added a commit
that referenced
this pull request
Aug 10, 2025
…) (#54327) Before that change, when you set custom variables or intialization in airflow-breeze-config, the initialization was kind of wrongly done. a) in case of regular breeze command, it was done AFTER db-reset b) when start-airflow was done, the initialization was done during the start-airflow - separately - which was kinda strangely duplicated This change unifies it - the initialization of custom variables and scripts happens before we run db-reset or check if we should start airflow. (cherry picked from commit 9334484) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Aug 15, 2025
Before that change, when you set custom variables or intialization in airflow-breeze-config, the initialization was kind of wrongly done. a) in case of regular breeze command, it was done AFTER db-reset b) when start-airflow was done, the initialization was done during the start-airflow - separately - which was kinda strangely duplicated This change unifies it - the initialization of custom variables and scripts happens before we run db-reset or check if we should start airflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before that change, when you set custom variables or intialization in airflow-breeze-config, the initialization was kind of wrongly done.
a) in case of regular breeze command, it was done AFTER db-reset b) when start-airflow was done, the initialization was done during
the start-airflow - separately - which was kinda strangely duplicated
This change unifies it - the initialization of custom variables and scripts happens before we run db-reset or check if we should start airflow.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.