Skip to content

Comments

Bump precommit hook version to 6.0.0#54345

Closed
amoghrajesh wants to merge 1 commit intoapache:mainfrom
amoghrajesh:upgrade-check-main
Closed

Bump precommit hook version to 6.0.0#54345
amoghrajesh wants to merge 1 commit intoapache:mainfrom
amoghrajesh:upgrade-check-main

Conversation

@amoghrajesh
Copy link
Contributor

Failure is on v3 branch: https://github.com/apache/airflow/actions/runs/16866558954/job/47774294749

But we need to bump on main and cherry pick too


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@eladkal
Copy link
Contributor

eladkal commented Aug 11, 2025

Failure is on v3 branch

Interesting. Why is the failure only on the v3 branch and not on main?

@amoghrajesh amoghrajesh requested a review from kaxil August 11, 2025 08:49
@amoghrajesh
Copy link
Contributor Author

I think it will fail on main too, it just hasnt run yet :)

@potiuk
Copy link
Member

potiuk commented Aug 11, 2025

Failure is on v3 branch

Interesting. Why is the failure only on the v3 branch and not on main?

Good point:

Apparently pre-commit autoupdate returns exit code = 0 even if there is an update done:

Screenshot 2025-08-11 at 10 52 24

So it gets also updated in canary builds, but it does not fail the build.

@potiuk
Copy link
Member

potiuk commented Aug 11, 2025

@amoghrajesh
Copy link
Contributor Author

Nice, I think v3 branch was failing due to flynt then.

@potiuk
Copy link
Member

potiuk commented Aug 11, 2025

#54346 -> will check if there are any updates.

@amoghrajesh
Copy link
Contributor Author

I do not think we need this one now, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants