Fix CloudComposerDAGRunSensor functionality #54351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
MaksYermak
force-pushed
the
fix-cloud-composer-dag-run-sensor
branch
from
f7380fb to
f99caa0
Compare
Contributor
|
Bugfix PRs normally requires unit tests to avoid regression of the bug |
shahar1
reviewed
Aug 11, 2025
Contributor
shahar1
left a comment
shahar1
left a comment
There was a problem hiding this comment.
Could you please add unit tests?
VladaZakharova
approved these changes
Aug 21, 2025
MaksYermak
force-pushed
the
fix-cloud-composer-dag-run-sensor
branch
from
f99caa0 to
02288ae
Compare
Contributor
Author
shahar1
approved these changes
Aug 21, 2025
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I have improved functionality for the
CloudComposerDAGRunSensorsensor. I added a check for emptydag_runsto prevent Sensor stops while it's waiting for DAG and, also, added atimeoutfor deferrable mode.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.