Skip to content

[v3-0-test] Update selective checks to run core tests when serialization files changes (#54423) #54426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaxil merged 1 commit into from
Aug 12, 2025
Merged

[v3-0-test] Update selective checks to run core tests when serialization files changes (#54423) #54426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dev/breeze/src/airflow_breeze/utils/selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,6 +913,11 @@ def _get_core_test_types_to_run(self) -> list[str]:
get_console().print(
"[warning]There are no core/other files. Only tests relevant to the changed files are run.[/]"
)

# run core tests if any changes in serialization files
if SelectiveCoreTestType.SERIALIZATION.value in candidate_test_types:
candidate_test_types.add(SelectiveCoreTestType.CORE.value)

# sort according to predefined order
sorted_candidate_test_types = sorted(candidate_test_types)
get_console().print("[warning]Selected core test type candidates to run:[/]")
Expand Down
2 changes: 1 addition & 1 deletion dev/breeze/tests/test_selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ def assert_outputs_are_printed(expected_outputs: dict[str, str], stderr: str):
"skip-pre-commits": ALL_SKIPPED_COMMITS_IF_NO_PROVIDERS_UI_AND_HELM_TESTS,
"upgrade-to-newer-dependencies": "false",
"core-test-types-list-as-strings-in-json": json.dumps(
[{"description": "Always...Serialization", "test_types": "Always Serialization"}]
[{"description": "Always...Serialization", "test_types": "Always Core Serialization"}]
),
"providers-test-types-list-as-strings-in-json": None,
"individual-providers-test-types-list-as-strings-in-json": None,
Expand Down
Loading