[v3-0-test] Ensure TaskInstance.end_date and duration are populated before invoking failure callbacks (#52729) #54458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efore invoking failure callbacks (#52729) * Fix: Set TaskInstance end_date before failure callbacks (#52630) - Set ti.end_date before creating TaskState in exception handlers - Ensures on_failure_callback context has proper end_date and duration - Fixes race condition where callbacks received incomplete TaskInstance data - Add test to verify callback context contains required timing information * Enhance task callbacks to include end_date and duration metrics (cherry picked from commit eda89ae) Co-authored-by: Ranuga Disansa <79456372+Programmer-RD-AI@users.noreply.github.com>
amoghrajesh
approved these changes
Aug 13, 2025
This was referenced Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit eda89ae)
Co-authored-by: Ranuga Disansa 79456372+Programmer-RD-AI@users.noreply.github.com