Skip to content

Conversation

@dabla
Copy link
Contributor

@dabla dabla commented Aug 13, 2025

Added support for Windows paths in SambaHook.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

closes: #47206
related: #47206

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! ... Wiindows-on-Posix support :)

I hope we wil have more of Windows support eventualy

@potiuk
Copy link
Member

potiuk commented Aug 15, 2025

BTW. A bit of rant - quite a few trillion USD mistake on letting Windows and "other standards" to diverge. Clearly cooperation and consensus is so much more difficult to achieve and so cheaper when actually achieved.

@potiuk potiuk merged commit 53ec9e1 into apache:main Aug 15, 2025
131 of 132 checks passed
@ashb
Copy link
Member

ashb commented Aug 16, 2025

This is failing in main

FAILED providers/samba/tests/unit/samba/hooks/test_samba.py::TestSambaHook::test__join_path[/start/path/with/slash/windows-windows-\\\\ip\\share\\start\\path\\with\\slash\\windows] - AssertionError: assert equals failed
  '\\\\\\ip\\\\share\\start\\path\\with\\slash\\windows'  '\\\\ip\\share\\start\\path\\with\\slash\\windows'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"apache-airflow-providers-samba" not working with Windows shares due to fixed use of forward slahes

3 participants