-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Added support for Windows paths in SambaHook #54459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Windows paths in SambaHook #54459
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! ... Wiindows-on-Posix support :)
I hope we wil have more of Windows support eventualy
|
BTW. A bit of rant - quite a few trillion USD mistake on letting Windows and "other standards" to diverge. Clearly cooperation and consensus is so much more difficult to achieve and so cheaper when actually achieved. |
|
This is failing in main |
This reverts commit 53ec9e1.
Added support for Windows paths in SambaHook.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.closes: #47206
related: #47206