-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Filter out empty logs in useLogs #54462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
is there a reason why we are getting empty logs? (i am not that familiar with the UI side of things, sorry if this is a obvious question) |
5d83c90 to
917bb8f
Compare
|
After investigation, the issue would occur in
We use |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker a3388cf v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
|
cc: @bbovenzi not sure if we're going to have a 3.0.6 or 3.1.0 but we should probably manually backport this, just in case |
|
Manual backport: #54628 |
Related Issue
Why
We filtered the logs by level by replacing them with empty strings, but they still remain in the log list.
airflow/airflow-core/src/airflow/ui/src/components/renderStructuredLog.tsx
Lines 117 to 123 in 33658f0
On the overview page, multiple
TaskLogPreviewinstances could exist at the same time, each holding a full list of logs. This overloads the virtual lists with state updates, eventually triggering the error:Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate.How
TaskLogPreviewbefore
Screen.Recording.2025-08-13.at.8.46.35.PM.mov
after
Screen.Recording.2025-08-13.at.8.44.55.PM.mov
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.