fix(messaging): improve MessageQueueTrigger logging and add tests #54492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug in
MessageQueueTrigger.When there are no matching providers, or multiple providers recognize the same queue, the logging code attempted to join provider class objects directly, causing:
MESSAGE_QUEUE_PROVIDERScontains a list of class objectsairflow/providers/common/messaging/src/airflow/providers/common/messaging/triggers/msg_queue.py
Line 38 in 5f29f4e
but
.join([ ... ])expects stringsairflow/providers/common/messaging/src/airflow/providers/common/messaging/triggers/msg_queue.py
Line 75 in 5f29f4e
Added new tests to cover various scenarios including:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.