Skip to content

Fix missing logs in UI for tasks in UP_FOR_RETRY state (#54544) #54547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ido177 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

Fix missing logs in UI for tasks in UP_FOR_RETRY state (#54544) #54547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion airflow-core/src/airflow/utils/log/file_task_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,9 @@ def _read(
if ti.state in (TaskInstanceState.RUNNING, TaskInstanceState.DEFERRED) and not has_k8s_exec_pod:
sources, served_logs = self._read_from_logs_server(ti, worker_log_rel_path)
source_list.extend(sources)
elif ti.state not in State.unfinished and not (local_logs or remote_logs):
elif (ti.state not in State.unfinished or ti.state == TaskInstanceState.UP_FOR_RETRY) and not (
local_logs or remote_logs
):
# ordinarily we don't check served logs, with the assumption that users set up
# remote logging or shared drive for logs for persistence, but that's not always true
# so even if task is done, if no local logs or remote logs are found, we'll check the worker
Expand Down