-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[AIRFLOW-53596] Add GSheetsHook API endpoint support (Part 1) #54560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 6 commits into
apache:main
from
dataengineervishal:providers/google-api-endpoint
Aug 18, 2025
Merged
[AIRFLOW-53596] Add GSheetsHook API endpoint support (Part 1) #54560
potiuk
merged 6 commits into
apache:main
from
dataengineervishal:providers/google-api-endpoint
Aug 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdai
reviewed
Aug 16, 2025
0e98349 to
2a3ecce
Compare
2a3ecce to
8d95868
Compare
Contributor
Author
|
@jroachgolf84 - Can you please review this? |
potiuk
reviewed
Aug 18, 2025
- Added 'api_endpoint' param to 'GSheetsHook' and 'GoogleSheetsCreateSpreadsheetOperator' - Allows using regional or private API endpoints (e.g: private.googleapis.com) - Updated docstrings and unit tests for the new parameter
8d95868 to
d3e7c14
Compare
Member
|
And conflicts need to be resolved now. |
jroachgolf84
approved these changes
Aug 18, 2025
Collaborator
jroachgolf84
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approval holds no weight, as I am not a committer to the project. However, these changes look good to me! Were you able to test this (outside of the unit tests) to validate this works?
gopidesupavan
approved these changes
Aug 18, 2025
potiuk
approved these changes
Aug 18, 2025
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
…#54560) * Add support for custom api_endpoint in Google Sheets hook/operator - Added 'api_endpoint' param to 'GSheetsHook' and 'GoogleSheetsCreateSpreadsheetOperator' - Allows using regional or private API endpoints (e.g: private.googleapis.com) - Updated docstrings and unit tests for the new parameter * Fix gsheet hook test case * Fix version * Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a custom API endpoint in the GSheetsHook. It allows targeting regional or private endpoints, enabling use cases such as private VPCs or restricted access to Google Sheets APIs.
Scope:
Note:
This is the first part of AIRFLOW-53596. Once this GSheets feature is merged, similar API endpoint support will be added for other Google services.
Testing: