Skip to content

Conversation

@dataengineervishal
Copy link
Contributor

This PR adds support for a custom API endpoint in the GSheetsHook. It allows targeting regional or private endpoints, enabling use cases such as private VPCs or restricted access to Google Sheets APIs.

Scope:

  • Added api_endpoint parameter to GSheetsHook.
  • Added unit tests for client creation with and without a custom endpoint.

Note:
This is the first part of AIRFLOW-53596. Once this GSheets feature is merged, similar API endpoint support will be added for other Google services.

Testing:

  • Unit tests for GSheetsHook with default and custom endpoints.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Aug 15, 2025
@potiuk potiuk force-pushed the providers/google-api-endpoint branch from 0e98349 to 2a3ecce Compare August 16, 2025 21:46
@dataengineervishal dataengineervishal force-pushed the providers/google-api-endpoint branch from 2a3ecce to 8d95868 Compare August 17, 2025 20:01
@dataengineervishal
Copy link
Contributor Author

@jroachgolf84 - Can you please review this?

- Added 'api_endpoint' param to 'GSheetsHook' and 'GoogleSheetsCreateSpreadsheetOperator'
- Allows using regional or private API endpoints (e.g: private.googleapis.com)
- Updated docstrings and unit tests for the new parameter
@potiuk
Copy link
Member

potiuk commented Aug 18, 2025

And conflicts need to be resolved now.

Copy link
Collaborator

@jroachgolf84 jroachgolf84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval holds no weight, as I am not a committer to the project. However, these changes look good to me! Were you able to test this (outside of the unit tests) to validate this works?

@potiuk potiuk merged commit f84610c into apache:main Aug 18, 2025
75 checks passed
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
…#54560)

* Add support for custom api_endpoint in Google Sheets hook/operator

- Added 'api_endpoint' param to 'GSheetsHook' and 'GoogleSheetsCreateSpreadsheetOperator'
- Allows using regional or private API endpoints (e.g: private.googleapis.com)
- Updated docstrings and unit tests for the new parameter

* Fix gsheet hook test case

* Fix version

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants