Remove end_from_trigger attribute in MwaaDagRunSensor trigger #54567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prdai
approved these changes
Aug 16, 2025
o-nikolas
approved these changes
Aug 18, 2025
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #54531 except for the MwaaDagRunSensor instead of the MwaaTaskSensor. The same change is needed for MwaaDagRunSensor and I forgot to include it in the other PR. Context:
Currently there's a bug that prevents MwaaDagRunSensor from working in deferrable mode. It refers to an attribute end_from_trigger, the intention is for the trigger to complete without spinning up a call to execute_complete. However, end_from_trigger is a new attribute not yet implemented for this trigger, so I removed it. Without this change, the example_mwaa.py system integration test fails when deferrable=True on the MwaaDagRunSensor, and after this change the same test passes.