chore(ui): remove redundant enabled check #54579
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyLee1224
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
guan404ming
approved these changes
Aug 17, 2025
Member
guan404ming
left a comment
guan404ming
left a comment
There was a problem hiding this comment.
LGTM, another quick review would help confirm I didn’t overlook anything
bbovenzi
approved these changes
Aug 18, 2025
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the redundant
enabled: !isNaN(pageSize)check from several API service hooks.This check was originally added as a defensive fix for a race condition (see #44989), but the underlying issue has been resolved in #45095 by using a router loader to ensure the page size config is always pre-loaded.
As a result, this enabled check is now redundant and can be removed. This cleanup was discussed in #54049 comment.
I have checked the affected pages locally. The original
offset=NaNbug does not reappear and that no new console errors are introduced after this PR.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.