Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Aug 18, 2025

We are building a small image for our release process to build our distributions in an isolated environment - and this image fails to build on ARM because there are no corresponding binary wheels released for prek so prek is built from sources when installed in this image. This image originally did not have build-essential which is needed in order to compile some of prek dependencies.

This PR temporary adds build-essential until prek will produce more binary wheels for more target platforms. This is tracked in j178/prek#451


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

We are building a small image for our release process to build our
distributions in an isolated environment - and this image fails
to build on ARM because there are no corresponding binary wheels
released for `prek` so prek is built from sources when installed
in this image. This image originally did not have build-essential
which is needed in order to compile some of prek dependencies.

This PR temporary adds build-essential until prek will produce
more binary wheels for more target platforms. This is
tracked in j178/prek#451
@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Aug 18, 2025
@potiuk potiuk requested a review from bugraoz93 August 18, 2025 12:25
@potiuk potiuk merged commit 50c1941 into apache:main Aug 18, 2025
22 checks passed
@potiuk potiuk deleted the add-build-essential-to-airflow-build-image branch August 18, 2025 12:28
github-actions bot pushed a commit that referenced this pull request Aug 18, 2025
We are building a small image for our release process to build our
distributions in an isolated environment - and this image fails
to build on ARM because there are no corresponding binary wheels
released for `prek` so prek is built from sources when installed
in this image. This image originally did not have build-essential
which is needed in order to compile some of prek dependencies.

This PR temporary adds build-essential until prek will produce
more binary wheels for more target platforms. This is
tracked in j178/prek#451
(cherry picked from commit 50c1941)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
@github-actions
Copy link

Backport successfully created: v3-0-test

Status Branch Result
v3-0-test PR Link

potiuk added a commit that referenced this pull request Aug 18, 2025
We are building a small image for our release process to build our
distributions in an isolated environment - and this image fails
to build on ARM because there are no corresponding binary wheels
released for `prek` so prek is built from sources when installed
in this image. This image originally did not have build-essential
which is needed in order to compile some of prek dependencies.

This PR temporary adds build-essential until prek will produce
more binary wheels for more target platforms. This is
tracked in j178/prek#451
(cherry picked from commit 50c1941)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit to potiuk/airflow that referenced this pull request Aug 18, 2025
This upgrades prek to **just released** 0.0.29 and removes the
workaround implemented in apache#54613 to add build-essential to the
image that is used to build distributions - because prek 0.0.29
comes with all the necessary binary wheels/platforms that remove
the need to build in in our Linux ARM image (issue
j178/prek#451 has been fixed).
@potiuk potiuk mentioned this pull request Aug 18, 2025
kaxil pushed a commit that referenced this pull request Aug 18, 2025
We are building a small image for our release process to build our
distributions in an isolated environment - and this image fails
to build on ARM because there are no corresponding binary wheels
released for `prek` so prek is built from sources when installed
in this image. This image originally did not have build-essential
which is needed in order to compile some of prek dependencies.

This PR temporary adds build-essential until prek will produce
more binary wheels for more target platforms. This is
tracked in j178/prek#451
(cherry picked from commit 50c1941)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit that referenced this pull request Aug 18, 2025
This upgrades prek to **just released** 0.0.29 and removes the
workaround implemented in #54613 to add build-essential to the
image that is used to build distributions - because prek 0.0.29
comes with all the necessary binary wheels/platforms that remove
the need to build in in our Linux ARM image (issue
j178/prek#451 has been fixed).
potiuk added a commit to potiuk/airflow that referenced this pull request Aug 18, 2025
This upgrades prek to **just released** 0.0.29 and removes the
workaround implemented in apache#54613 to add build-essential to the
image that is used to build distributions - because prek 0.0.29
comes with all the necessary binary wheels/platforms that remove
the need to build in in our Linux ARM image (issue
j178/prek#451 has been fixed).
(cherry picked from commit a4fa218)

Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
potiuk added a commit that referenced this pull request Aug 18, 2025
This upgrades prek to **just released** 0.0.29 and removes the
workaround implemented in #54613 to add build-essential to the
image that is used to build distributions - because prek 0.0.29
comes with all the necessary binary wheels/platforms that remove
the need to build in in our Linux ARM image (issue
j178/prek#451 has been fixed).
(cherry picked from commit a4fa218)
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
This upgrades prek to **just released** 0.0.29 and removes the
workaround implemented in apache#54613 to add build-essential to the
image that is used to build distributions - because prek 0.0.29
comes with all the necessary binary wheels/platforms that remove
the need to build in in our Linux ARM image (issue
j178/prek#451 has been fixed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants