feat: Implemented Filters UI for Asset Events View #54640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianLii
changed the title
BrianLii
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
guan404ming
reviewed
Aug 25, 2025
Member
There was a problem hiding this comment.
Thanks for the PR, the direction looks good! I've left some comments on it. Also, I think there are still two things needed in this PR:
-
need to add labels for
start dateandend datefields -
make the layout more consistent with current filters, you could take a look at this one https://github.com/apache/airflow/pull/54049/files
-
(optional) reset filter feature is also needed (could be done in follow up one)
cc @RoyLee1224 I think you are more familiar with filter please help give it a quick look if you have time. Thanks!
airflow-core/src/airflow/ui/src/components/Assets/AssetEvents.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/components/Assets/AssetEvents.tsx
Outdated
Show resolved
Hide resolved
airflow-core/src/airflow/ui/src/components/Assets/AssetEvents.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @guan404ming for the review! |
BrianLii
force-pushed
the
feat-asset-view-filter
branch
from
71c9a9a to
5b18a59
Compare
Member
pierrejeambrun
left a comment
pierrejeambrun
left a comment
There was a problem hiding this comment.
Similarly to other filtering options, can you handle the reset filter button too?
airflow-core/src/airflow/ui/src/components/Assets/AssetEvents.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I've also implemented the reset button, similar to the counterpart in |
Contributor
|
UI Looks good to me, nice fix 💪 |
Contributor
|
Functionality looks good. Let's rebase to use the new components from #54895 |
bbovenzi
approved these changes
Sep 11, 2025
Contributor
bbovenzi
left a comment
bbovenzi
left a comment
There was a problem hiding this comment.
Actually functionality looks good. We can update the UX in another PR
pierrejeambrun
changed the title
kaxil
pushed a commit
that referenced
this pull request
Sep 11, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io> (cherry picked from commit 9385762)
5 tasks
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Brunda10
pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* feat: implemented filter timestamp * refactor: minor * feat: remove key for the date input * feat: add run and dag filter * feat: add selector for run type * fix: fix translation for selector label * fix: add empty option in the selector * refactor: move filter variables to utils * fix: bug of total_entries * feat: add label * feat: beautify UI * feat: add label for searchbar * feat: use backend filter * feat: move filter components to AssetEventsFilter * feat: add reset button * fix: remove unused translation package * fix: remove unused translation package * feat: update reset ui * refactor: adjust the order of variables * refactor: move paramkeys to global * feat: conditionally render filter * refactor: rename showFilters --------- Co-authored-by: Brent Bovenzi <brent@astronomer.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #53053
This PR implements the filtering UI for viewing asset events. The filters include:
Timestamp -- date picker
DAG ID -- search bar with substring matching
Task ID -- search bar with substring matching
Demo:
https://github.com/user-attachments/assets/cfb496d2-fb84-4663-937c-7a61fa91526a