Skip to content

Conversation

@uranusjr
Copy link
Member

Close #54627. See in-code comments for details.

@uranusjr uranusjr added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Aug 19, 2025
@uranusjr uranusjr force-pushed the remove-start-from-trigger branch 3 times, most recently from f290086 to 2ce1736 Compare August 19, 2025 09:11
@uranusjr uranusjr marked this pull request as ready for review August 19, 2025 09:52
@uranusjr uranusjr requested review from XD-DENG and ashb as code owners August 19, 2025 09:52
@ashb
Copy link
Member

ashb commented Aug 19, 2025

What do we have to do to re-enable it for 3.1 timeframe?

@uranusjr uranusjr force-pushed the remove-start-from-trigger branch from 2ce1736 to d98bb86 Compare August 20, 2025 01:23
@uranusjr
Copy link
Member Author

We need to figure out how to render the task template without spawning a worker (or at least be able to spawn a process that’s significantly more lightweight than a task worker) to make this worthwhile. Otherwise I feel we should just remove this feature altogether since it would not provide any benefits.

@uranusjr uranusjr merged commit 91e1029 into apache:main Aug 20, 2025
57 checks passed
@uranusjr uranusjr deleted the remove-start-from-trigger branch August 20, 2025 02:27
@github-actions
Copy link

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 91e1029 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

@uranusjr
Copy link
Member Author

Not going to backport per suggestion from @vatsrahul1001. This issue is not repro-able in 3.0.x.

@dabla
Copy link
Contributor

dabla commented Aug 20, 2025

We need to figure out how to render the task template without spawning a worker (or at least be able to spawn a process that’s significantly more lightweight than a task worker) to make this worthwhile. Otherwise I feel we should just remove this feature altogether since it would not provide any benefits.

I have a PR open for that, it's a pity this has been closed as my PR is ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scheduler crashing when running mapped task

6 participants