-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Remove black usage in prek hooks #54656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We are not using black-related functionality in prek hooks any more - the only remaining hook is 'blacken-docs` - but there is no need to synchronize and upgrade black version any more for it. Upgraded to latest black version for blacken-docs manually.
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
|
Somewhat relatedly, I wonder if we should switch these scripts from |
+1 |
If prek will supports it - yes absolutely but I doubt it does - @j178 - what do you think ? Can prek support inline dependencies when creating venvs ? I think pre-commit did the optimisation that it reused the venvs if they had the same deps - but with |
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker 4e6fa29 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
We are not using black-related functionality in prek hooks any more - the only remaining hook is 'blacken-docs` - but there is no need to synchronize and upgrade black version any more for it. Upgraded to latest black version for blacken-docs manually. (cherry picked from commit 4e6fa29)
We are not using black-related functionality in prek hooks any more - the only remaining hook is 'blacken-docs` - but there is no need to synchronize and upgrade black version any more for it. Upgraded to latest black version for blacken-docs manually. (cherry picked from commit 4e6fa29) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
|
Created an issue in |
We are not using black-related functionality in prek hooks any more - the only remaining hook is 'blacken-docs` - but there is no need to synchronize and upgrade black version any more for it. Upgraded to latest black version for blacken-docs manually.
We are not using black-related functionality in prek hooks any more - the only remaining hook is 'blacken-docs` - but there is no need to synchronize and upgrade black version any more for it.
Upgraded to latest black version for blacken-docs manually.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.