-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix remote logging connection availability in Task SDK supervisor #54679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Aug 19, 2025
This comment was marked as spam.
This comment was marked as spam.
ashb
approved these changes
Aug 20, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Aug 20, 2025
…pervisor (#54679) Using connections stored in the Airflow Metadata for Remote logging was partially fixed in 3.0.4, but the connection was only set/put-in-scope when the logger was created before task startup. However for blob stores (i.e. S3 or WASB) that is a no-op, and we needed the connection when we try to upload too. (cherry picked from commit b340e8c) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
github-actions bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Aug 20, 2025
…pervisor (apache#54679) Using connections stored in the Airflow Metadata for Remote logging was partially fixed in 3.0.4, but the connection was only set/put-in-scope when the logger was created before task startup. However for blob stores (i.e. S3 or WASB) that is a no-op, and we needed the connection when we try to upload too. (cherry picked from commit b340e8c) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
ashb
pushed a commit
that referenced
this pull request
Aug 20, 2025
…pervisor (#54679) (#54720) Using connections stored in the Airflow Metadata for Remote logging was partially fixed in 3.0.4, but the connection was only set/put-in-scope when the logger was created before task startup. However for blob stores (i.e. S3 or WASB) that is a no-op, and we needed the connection when we try to upload too. (cherry picked from commit b340e8c) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
…ache#54679) Using connections stored in the Airflow Metadata for Remote logging was partially fixed in 3.0.4, but the connection was only set/put-in-scope when the logger was created before task startup. However for blob stores (i.e. S3 or WASB) that is a no-op, and we needed the connection when we try to upload too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #54603
Remote logging was only working when creating connections using env var. When connections were created via Airflow UI, remote logging failed with below error
{"event":"Unable to find AWS Connection ID 'worker_remote_log_s3_conn', switching to empty.","level":"warning","logger":"airflow.task.hooks.airflow.providers.amazon.aws.hooks.s3.S3Hook","timestamp":"2025-08-18T08:15:49.647380Z"}This PR addresses the timing issue. Also add caching
Testing
LOGS