feat(hitl): record HITLDetail action in audit log #54767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
requested review from
bugraoz93,
ephraimbuddy,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
Lee-W
force-pushed
the
record-hitl-action-in-audit-log
branch
2 times, most recently
from
5aee9f3 to
488f12f
Compare
jason810496
approved these changes
Aug 22, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Nice! LGTM.
Only one small question regarding #54723 in the moment.
airflow-core/src/airflow/api_fastapi/core_api/routes/public/hitl.py
Outdated
Show resolved
Hide resolved
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_hitl.py
Outdated
Show resolved
Hide resolved
jason810496
requested changes
Aug 22, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
The CI still need fix, just dismissed my approve to avoid accidentally merge.
Member
Author
yep, some test failed. Will need to resolve conflict after #54723 |
Lee-W
force-pushed
the
record-hitl-action-in-audit-log
branch
from
488f12f to
17ba55f
Compare
jason810496
approved these changes
Aug 22, 2025
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
close: #54694
What
Record HITLDetail action in the audit log when user respond to hitl detail on Airflow UI
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.