Retry on 409 conflict #54777
Merged
Retry on 409 conflict #54777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romsharon98
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
potiuk
approved these changes
Aug 21, 2025
Member
|
Some tests fail :( |
eladkal
approved these changes
Aug 23, 2025
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
* Retry on 409 conflict * Change comment * linting * change or and hirarchy --------- Co-authored-by: rom-impala <rom@getimpala.ai>
nothingmin
pushed a commit
to nothingmin/airflow
that referenced
this pull request
Sep 2, 2025
* Retry on 409 conflict * Change comment * linting * change or and hirarchy --------- Co-authored-by: rom-impala <rom@getimpala.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Airflow with the KubernetesExecutor (4 schedulers, kubernetes.worker_pods_creation_batch_size=16), pod creation occasionally fails with:
Pod creation failed with reason 'Conflict'This happens because the namespace has a ResourceQuota. When multiple pods are created simultaneously, the quota controller must update the ResourceQuota object to reflect new usage. Concurrent updates cause a 409 Conflict, and the admission of some pods fails. As a result, the corresponding Airflow tasks are marked as failed even though there are still available resources under the quota.
This PR addresses the issue by adding a retry mechanism for pod creation when a 409 Conflict is encountered, ensuring tasks are not marked as failed due to transient quota update conflicts.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.