[v3-0-test] Ensure that Connection extra can get masked without causing an error (#54769) #54780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng an error (#54769) * Ensure that Connection extra can get masked without causing an error Fixes #54768 This was caused by pydantic#9541 and improper testing on my part. Sorry folks. Thsi happens because `Iterable` is too open-ended a type Yes, this should absolutely have unit tests to go with the fix, but a fix is better than nothing, and I'm about to leave on a camping holiday. * fixup! Ensure that Connection extra can get masked without causing an error * fixup! fixup! Ensure that Connection extra can get masked without causing an error * fixup! fixup! fixup! Ensure that Connection extra can get masked without causing an error --------- (cherry picked from commit 5aec867) Co-authored-by: Ash Berlin-Taylor <ash@apache.org> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
kaxil
approved these changes
Aug 21, 2025
amoghrajesh
approved these changes
Aug 21, 2025
kaxil
pushed a commit
that referenced
this pull request
Aug 22, 2025
…ng an error (#54769) (#54780) * Ensure that Connection extra can get masked without causing an error Fixes #54768 This was caused by pydantic#9541 and improper testing on my part. Sorry folks. Thsi happens because `Iterable` is too open-ended a type Yes, this should absolutely have unit tests to go with the fix, but a fix is better than nothing, and I'm about to leave on a camping holiday. * fixup! Ensure that Connection extra can get masked without causing an error * fixup! fixup! Ensure that Connection extra can get masked without causing an error * fixup! fixup! fixup! Ensure that Connection extra can get masked without causing an error --------- (cherry picked from commit 5aec867) Co-authored-by: Ash Berlin-Taylor <ash@apache.org> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54768
This was caused by pydantic#9541 and improper testing on my part. Sorry
folks. Thsi happens because
Iterableis too open-ended a typeYes, this should absolutely have unit tests to go with the fix, but a fix is
better than nothing, and I'm about to leave on a camping holiday.
fixup! Ensure that Connection extra can get masked without causing an error
fixup! fixup! Ensure that Connection extra can get masked without causing an error
fixup! fixup! fixup! Ensure that Connection extra can get masked without causing an error
(cherry picked from commit 5aec867)
Co-authored-by: Ash Berlin-Taylor ash@apache.org
Co-authored-by: Jarek Potiuk jarek@potiuk.com