Skip to content

Remove duplicate "concurrency" from dag details #54801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bbovenzi merged 3 commits into from
Aug 25, 2025
Merged

Remove duplicate "concurrency" from dag details #54801

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
305f6a4
Remove duplicate "concurrency" from dag details
jedcunningham Aug 21, 2025
2a0a2c1
Remove `dagDetails.concurrency` translation.
jedcunningham Aug 22, 2025
cdefd04
Deprecate the concurrency field in the api
jedcunningham Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion airflow-core/src/airflow/api_fastapi/core_api/datamodels/dags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,11 @@ def get_params(cls, params: abc.MutableMapping | None) -> dict | None:
@computed_field # type: ignore[prop-decorator]
@property
def concurrency(self) -> int:
"""Return max_active_tasks as concurrency."""
"""
Return max_active_tasks as concurrency.

Deprecated: Use max_active_tasks instead.
"""
return self.max_active_tasks

# Mypy issue https://github.com/python/mypy/issues/1362
Expand Down
5 changes: 4 additions & 1 deletion airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9156,7 +9156,10 @@ components:
concurrency:
type: integer
title: Concurrency
description: Return max_active_tasks as concurrency.
description: 'Return max_active_tasks as concurrency.


Deprecated: Use max_active_tasks instead.'
readOnly: true
latest_dag_version:
anyOf:
Expand Down
4 changes: 3 additions & 1 deletion airflow-core/src/airflow/ui/openapi-gen/requests/schemas.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1950,7 +1950,9 @@ export const $DAGDetailsResponse = {
concurrency: {
type: 'integer',
title: 'Concurrency',
description: 'Return max_active_tasks as concurrency.',
description: `Return max_active_tasks as concurrency.

Deprecated: Use max_active_tasks instead.`,
readOnly: true
},
latest_dag_version: {
Expand Down
2 changes: 2 additions & 0 deletions airflow-core/src/airflow/ui/openapi-gen/requests/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,6 +541,8 @@ export type DAGDetailsResponse = {
readonly file_token: string;
/**
* Return max_active_tasks as concurrency.
*
* Deprecated: Use max_active_tasks instead.
*/
readonly concurrency: number;
/**
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/ar/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
"dag_zero": "لا يوجد أي Dag",
"dagDetails": {
"catchup": "إلحاق",
"concurrency": "تزامن",
"dagRunTimeout": "مهلة تشغيل الDag",
"defaultArgs": "متغيرات افتراضية",
"description": "وصف",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/de/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"dag_other": "Dags",
"dagDetails": {
"catchup": "Nachgeholt",
"concurrency": "Parallelität",
"dagRunTimeout": "Dag Lauf Zeitüberschreitung",
"defaultArgs": "Standard-Parameter",
"description": "Beschreibung",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/en/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"dag_other": "Dags",
"dagDetails": {
"catchup": "Catchup",
"concurrency": "Concurrency",
"dagRunTimeout": "Dag Run Timeout",
"defaultArgs": "Default Args",
"description": "Description",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/es/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"dag_other": "Dags",
"dagDetails": {
"catchup": "Catchup",
"concurrency": "Concurrencia",
"dagRunTimeout": "Tiempo de Ejecución del Dag",
"defaultArgs": "Argumentos por Defecto",
"description": "Descripción",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/fr/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
"dag_other": "Dags",
"dagDetails": {
"catchup": "Rattrapage",
"concurrency": "Concurrence",
"dagRunTimeout": "Délai d'exécution du Dag",
"defaultArgs": "Arguments par défaut",
"description": "Description",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/he/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"dag_other": "Dags",
"dagDetails": {
"catchup": "השלמה אוטומטית",
"concurrency": "מספר הרצות מקבילות",
"dagRunTimeout": "זמן תפוגה להרצת Dag",
"defaultArgs": "פרמטרי ברירת מחדל",
"description": "תיאור",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/ko/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"dag_other": "Dags",
"dagDetails": {
"catchup": "캐치업",
"concurrency": "동시 샐행 수",
"dagRunTimeout": "Dag 실행 제한 시간",
"defaultArgs": "기본 인자",
"description": "설명",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/nl/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"dag_other": "Dags",
"dagDetails": {
"catchup": "Catchup",
"concurrency": "Concurrency",
"dagRunTimeout": "Dag Run timeout",
"defaultArgs": "Standaard argumenten",
"description": "Omschrijving",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/pl/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
"dag_other": "Dagi",
"dagDetails": {
"catchup": "Nadrabianie zaległości",
"concurrency": "Współbieżność",
"dagRunTimeout": "Limit czasu wykonania",
"defaultArgs": "Domyślne argumenty",
"description": "Opis",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/tr/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"dag_other": "Dag'ler",
"dagDetails": {
"catchup": "Yakalama",
"concurrency": "Eş Zamanlılık",
"dagRunTimeout": "Dag Çalıştırma Zaman Aşımı",
"defaultArgs": "Varsayılan Argümanlar",
"description": "Açıklama",
Expand Down
1 change: 0 additions & 1 deletion airflow-core/src/airflow/ui/public/i18n/locales/zh-TW/common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"dag_other": "Dags",
"dagDetails": {
"catchup": "自動回填",
"concurrency": "並行數",
"dagRunTimeout": "Dag 執行超時",
"defaultArgs": "預設參數",
"description": "描述",
Expand Down
4 changes: 0 additions & 4 deletions airflow-core/src/airflow/ui/src/pages/Dag/Details.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,6 @@ export const Details = () => {
<Time datetime={dag.last_expired} />
</Table.Cell>
</Table.Row>
<Table.Row>
<Table.Cell>{translate("dagDetails.concurrency")}</Table.Cell>
<Table.Cell>{dag.concurrency}</Table.Cell>
</Table.Row>
<Table.Row>
<Table.Cell>{translate("dagDetails.hasTaskConcurrencyLimits")}</Table.Cell>
<Table.Cell>{dag.has_task_concurrency_limits.toString()}</Table.Cell>
Expand Down
6 changes: 5 additions & 1 deletion airflow-ctl/src/airflowctl/api/datamodels/generated.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,7 +1252,11 @@ class DAGDetailsResponse(BaseModel):
owner_links: Annotated[dict[str, str] | None, Field(title="Owner Links")] = None
file_token: Annotated[str, Field(description="Return file token.", title="File Token")]
concurrency: Annotated[
int, Field(description="Return max_active_tasks as concurrency.", title="Concurrency")
int,
Field(
description="Return max_active_tasks as concurrency.\n\nDeprecated: Use max_active_tasks instead.",
title="Concurrency",
),
]
latest_dag_version: Annotated[
DagVersionResponse | None, Field(description="Return the latest DagVersion.")
Expand Down
Loading