Add Support for GitHub App Installation Authentication in GithubHook#54812
Merged
Lee-W merged 9 commits intoapache:mainfrom Nov 22, 2025
Merged
Add Support for GitHub App Installation Authentication in GithubHook#54812Lee-W merged 9 commits intoapache:mainfrom
GithubHook#54812Lee-W merged 9 commits intoapache:mainfrom
Conversation
Lee-W
reviewed
Nov 4, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
hey sorry for late review. left a few comments. but I think we're close to merge
eladkal
changed the title
GithubHook
Member
|
still need some fix on CI failure. will take a look tomorrow |
Lee-W
approved these changes
Nov 20, 2025
jason810496
reviewed
Nov 20, 2025
Member
jason810496
left a comment
jason810496
left a comment
There was a problem hiding this comment.
Thanks for the update! Please feel free to resolve the addressed comments.
Sorry I should raise the nit in previous review:
How about adding unit test for get_conn method to check the new branch logic?
Thanks!
Contributor
Author
Thanks for addressing this! |
62 tasks
itayweb
pushed a commit
to itayweb/airflow
that referenced
this pull request
Dec 6, 2025
dym-ok
added a commit
to dym-ok/airflow
that referenced
this pull request
Jan 16, 2026
This PR adds support for GitHub App private keys stored directly in connections (e.g. in AWS Secrets Manager). `private_key` field is an alternative to `key_path`. This is a followup for apache#54812.
dym-ok
added a commit
to dym-ok/airflow
that referenced
this pull request
Feb 2, 2026
This PR adds support for GitHub App private keys stored directly in connections (e.g. in AWS Secrets Manager). `private_key` field is an alternative to `key_path`. This is a followup for apache#54812.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #39457
Summary
This PR add support for GitHub App Installation Authentication in
GithubHook.If
access_tokenis not provided, readkey_path,app_id,installation_id, and optionaltoken_permissionsfrom extra field.Other Change
Related Document
Github app document
Example app installation authentication
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.