-
Notifications
You must be signed in to change notification settings - Fork 16.3k
feat(hitl): add utility functions for generating the url to required actions page #54827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hitl): add utility functions for generating the url to required actions page #54827
Conversation
7249bb0 to
3e07ab8
Compare
722feb2 to
9c7d5d8
Compare
9c7d5d8 to
7ab83d4
Compare
|
cc @guan404ming |
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! That is a good helper!
Can you also in #54783 (or here?) reference this in some kind of documentation such that users can find this helper?
yep, this will be added to the HITL tutorial page. I thought of making that a separate PR, but after a second thought, I could probably just update this one. |
a775a13 to
6835c73
Compare
|
Hey @jscheffl , I just rewrote the function with an example and doc update. Would be nice if you can take another look thanks! |
jason810496
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for the PR!
The nits are non-blocking and can be done in follow-up.
Cool! Thanks! |
…sier notifier calling
…t to hitl tutoiral
…only the necessary arg
3b7d907 to
6731408
Compare
|
I'm going to merge this one as the functionality is ready and it improves the doc. I will create a separate PR if the detail is changed in #54783 |
Why
An easy way for users to leverage the functionality in #54783
closes: #54696
What
Add the utility method
HITLOperator.generate_link_to_uiandHITLOperator.generate_link_to_ui_through_contextto generate the link to the required action tab on Airflow with pre-defined data.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.