Skip to content

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Aug 22, 2025

Why

An easy way for users to leverage the functionality in #54783

closes: #54696

What

Add the utility method HITLOperator.generate_link_to_ui and HITLOperator.generate_link_to_ui_through_context to generate the link to the required action tab on Airflow with pre-defined data.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@Lee-W Lee-W force-pushed the add-utility-method-for-generating-hitl-ui-url branch from 7249bb0 to 3e07ab8 Compare August 25, 2025 01:36
@Lee-W Lee-W moved this to In progress in AIP-90 - Human in the loop Aug 25, 2025
@Lee-W Lee-W self-assigned this Aug 25, 2025
@Lee-W Lee-W force-pushed the add-utility-method-for-generating-hitl-ui-url branch 2 times, most recently from 722feb2 to 9c7d5d8 Compare August 25, 2025 13:03
@Lee-W Lee-W marked this pull request as ready for review August 25, 2025 14:33
@Lee-W Lee-W force-pushed the add-utility-method-for-generating-hitl-ui-url branch from 9c7d5d8 to 7ab83d4 Compare August 25, 2025 14:34
@Lee-W Lee-W requested review from jason810496 and jscheffl August 25, 2025 14:36
@Lee-W
Copy link
Member Author

Lee-W commented Aug 25, 2025

cc @guan404ming

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! That is a good helper!

Can you also in #54783 (or here?) reference this in some kind of documentation such that users can find this helper?

@Lee-W
Copy link
Member Author

Lee-W commented Aug 26, 2025

Cool! That is a good helper!

Can you also in #54783 (or here?) reference this in some kind of documentation such that users can find this helper?

yep, this will be added to the HITL tutorial page. I thought of making that a separate PR, but after a second thought, I could probably just update this one.

@Lee-W Lee-W force-pushed the add-utility-method-for-generating-hitl-ui-url branch 2 times, most recently from a775a13 to 6835c73 Compare August 26, 2025 11:21
@Lee-W Lee-W changed the title feat(hitl): add utility function generate_link_to_ui feat(hitl): add utility functions for generating the url to required actions page Aug 26, 2025
@Lee-W Lee-W moved this from In progress to In review in AIP-90 - Human in the loop Aug 26, 2025
@Lee-W
Copy link
Member Author

Lee-W commented Aug 26, 2025

Hey @jscheffl , I just rewrote the function with an example and doc update. Would be nice if you can take another look thanks!

Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR!
The nits are non-blocking and can be done in follow-up.

@jscheffl
Copy link
Contributor

Hey @jscheffl , I just rewrote the function with an example and doc update. Would be nice if you can take another look thanks!

Cool! Thanks!

@Lee-W Lee-W force-pushed the add-utility-method-for-generating-hitl-ui-url branch from 3b7d907 to 6731408 Compare August 27, 2025 01:26
@Lee-W
Copy link
Member Author

Lee-W commented Aug 27, 2025

I'm going to merge this one as the functionality is ready and it improves the doc. I will create a separate PR if the detail is changed in #54783

@Lee-W Lee-W merged commit 786ceec into apache:main Aug 27, 2025
185 of 204 checks passed
@Lee-W Lee-W deleted the add-utility-method-for-generating-hitl-ui-url branch August 27, 2025 08:41
@github-project-automation github-project-automation bot moved this from In review to Done in AIP-90 - Human in the loop Aug 27, 2025
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
nothingmin pushed a commit to nothingmin/airflow that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add example to add required actions tab link

3 participants