PostgresDialect should use index instead of name in get_column_names and get_primary_keys #54832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s are list of tuples, not list of dicts
This reverts commit 244b889.
… back filtering through predicate
potiuk
approved these changes
Aug 22, 2025
Contributor
Author
|
Thx @potiuk |
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
…and get_primary_keys (apache#54832) * fix: PostgresDialect should use index instead of name as returned rows are list of tuples, not list of dicts * refactor: Updated TestPostgresDialect * Revert "refactor: Updated TestPostgresDialect" This reverts commit 244b889. * refactor: Refactored get_column_names in PostgresDialect so it allows back filtering through predicate * refactor: Also take into account autoincrement columns in PostgresDialect * refactor: Fixed mocking of records in TestPostgresDialect * refactor: Reformatted get_column_names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgresDialect should use index instead of name in get_primary_keys as returned rows are list of tuples, not list of dicts in Postgres. For the get_column_names, the method schould map the rertuned tuples in a dict which respects the same format as SQLAlchemy uses so it's cross dialect compatible weather the native implementation is used or the SQLAlchemy one.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.