Refactor Kubernetes Executor Types to NamedTuples #54858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HsiuChuanHsu
requested review from
hussein-awala and
jedcunningham
as code owners
boring-cyborg
bot
added
area:providers
provider:cncf-kubernetes
DIPU167
approved these changes
Aug 23, 2025
hterik
reviewed
Aug 25, 2025
...cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor_types.py
Outdated
Show resolved
Hide resolved
...iders/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py
Outdated
Show resolved
Hide resolved
HsiuChuanHsu
force-pushed
the
refactor/kubernetes-types-to-namedtuple
branch
from
7af7305 to
07e01a5
Compare
Member
|
Need to fix CI. |
HsiuChuanHsu
requested review from
ashb,
gopidesupavan,
jason810496 and
potiuk
as code owners
jason810496
reviewed
Aug 26, 2025
Member
There was a problem hiding this comment.
Nice! Thanks for the PR!
LGTM if CI run is successful.
Unfortunately, linting still needs to be fixed in this run. It can be automatically resolved by using prek (the alternative to pre-commit we recently switched to) with the following command.
prek ruff --all-files && prek run ruff-format --all-files
HsiuChuanHsu
force-pushed
the
refactor/kubernetes-types-to-namedtuple
branch
from
a81a4d7 to
27251fe
Compare
Replace complex tuple type aliases with NamedTuple classes for better readability and maintainability: - KubernetesResults: key, state, pod_name, namespace, resource_version, failure_details - KubernetesWatch: pod_name, namespace, state, annotations, resource_version, failure_details - KubernetesJob: key, command, kube_executor_config, pod_template_file
…adability Replace tuple type aliases with structured NamedTuple classes in Kubernetes executor to improve code maintainability and type safety.
…tesResults object - Simplify _change_state method signature from 5 parameters to 1 KubernetesResults object - Update method calls in sync() and _flush_result_queue() to pass KubernetesResults directly - Update all test cases to create KubernetesResults objects instead of passing individual parameters
…ject Update test_pod_failure_logging_with_container_terminated to create KubernetesResults object Update test_pod_failure_logging_exception_handling to use new _change_state signature Update test_pod_failure_logging_non_failed_state to use KubernetesResults object - Remove unused FailureDetails import - Format KubernetesResults constructor calls for better readability
HsiuChuanHsu
force-pushed
the
refactor/kubernetes-types-to-namedtuple
branch
from
27251fe to
bcb1a51
Compare
Contributor
Author
|
Finally pass the CI test! Thanks for all of review. |
jason810496
approved these changes
Aug 27, 2025
uranusjr
force-pushed
the
refactor/kubernetes-types-to-namedtuple
branch
from
e53394e to
bcb1a51
Compare
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
nothingmin
pushed a commit
to nothingmin/airflow
that referenced
this pull request
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When working on #54115, a good suggestion from @hterik that we should refactors the Kubernetes executor type to make for better readability.
This PR refactors the Kubernetes executor type system by converting simple tuple aliases to structured
NamedTupleclasses.Changes Made
Type System Improvements
KubernetesResultsType→KubernetesResults(NamedTuple)KubernetesWatchType→KubernetesWatch(NamedTuple)KubernetesJobType→KubernetesJob(NamedTuple)Code Updates
kubernetes_executor_types.py: Define new NamedTuple classes with proper typingkubernetes_executor_utils.py: Modify usage patterns to work with NamedTupleskubernetes_executor.py: Refactor result handling logic for new type structuretest_kubernetes_executor.py: Adjust test assertions to work with named fields^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.