Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Aug 23, 2025

  • Dynamically detect shared distributions in selective checks
  • Run the tests as matrix
  • Skip cleaning the worker and setting up docker and breeze
  • Install the version of uv that we are bound with
  • Run tests in parallel wiht xdist

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Aug 23, 2025
@potiuk potiuk removed the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Aug 23, 2025
@potiuk potiuk force-pushed the dynamic-tests-for-shared-distributions branch 3 times, most recently from 8af117b to 1206ea8 Compare August 23, 2025 09:00
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One qn: if changes are made in shared/timezones, will it run tests only for that or for all shared?

@potiuk
Copy link
Member Author

potiuk commented Aug 23, 2025

One qn: if changes are made in shared/timezones, will it run tests only for that or for all shared?

All tests. They are fast in case of those shared utils. I prefer to run them always for everything (similarly as we run always all prek hook for --all-files in CI

* Dynamically detect shared distributions in selective checks
* Run the tests as matrix
* Skip cleaning the worker and setting up docker and breeze
* Install the version of uv that we are bound with
* Run tests in parallel with xdist
@potiuk potiuk force-pushed the dynamic-tests-for-shared-distributions branch from 1206ea8 to 4f0f343 Compare August 23, 2025 09:18
@potiuk
Copy link
Member Author

potiuk commented Aug 23, 2025

All tests. They are fast in case of those shared utils. I prefer to run them always for everything (similarly as we run always all prek hook for --all-files in CI

  • 40 s for test (including env setup) ... Not worth to risk selective checks for those (at least not for now).

Copy link
Member

@gopidesupavan gopidesupavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@gopidesupavan
Copy link
Member

All tests. They are fast in case of those shared utils. I prefer to run them always for everything (similarly as we run always all prek hook for --all-files in CI

  • 40 s for test (including env setup) ... Not worth to risk selective checks for those (at least not for now).

make sense as these components are very critical running always good choice :).

@amoghrajesh
Copy link
Contributor

One qn: if changes are made in shared/timezones, will it run tests only for that or for all shared?

All tests. They are fast in case of those shared utils. I prefer to run them always for everything (similarly as we run always all prek hook for --all-files in CI

Yep, I was expecting that too. The shared components also could inter depend on each other, so it would make sense too

@potiuk
Copy link
Member Author

potiuk commented Aug 23, 2025

Random k8s tests

@potiuk potiuk merged commit 7765867 into apache:main Aug 23, 2025
104 of 105 checks passed
@potiuk potiuk deleted the dynamic-tests-for-shared-distributions branch August 23, 2025 10:40
@amoghrajesh
Copy link
Contributor

Nice thanks @potiuk!

mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
* Dynamically detect shared distributions in selective checks
* Run the tests as matrix
* Skip cleaning the worker and setting up docker and breeze
* Install the version of uv that we are bound with
* Run tests in parallel with xdist
nothingmin pushed a commit to nothingmin/airflow that referenced this pull request Sep 2, 2025
* Dynamically detect shared distributions in selective checks
* Run the tests as matrix
* Skip cleaning the worker and setting up docker and breeze
* Install the version of uv that we are bound with
* Run tests in parallel with xdist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants