Skip to content

Conversation

@Thanush-03
Copy link

I have successfully implemented the trigger form URL feature for Airflow 3, which addresses Issue #54800. This feature restores the functionality that was available in Airflow 2.7+ but was missing in Airflow 3, allowing users to directly access the trigger form via URL with pre-populated fields.

Key Features Implemented

  1. Direct URL Access
    New route: /dags/{dagId}/trigger
    Full-page trigger form accessible via direct URL
    Added "Trigger" tab to DAG details page
  2. URL Parameter Support
    The trigger form now supports these URL parameters:
    conf: JSON configuration string for DAG run parameters
    dag_run_id: Custom run ID for the DAG run
    logical_date: Logical date for the DAG run (ISO format)
    note: Note/description for the DAG run.

Modified Files:

airflow-core/src/airflow/ui/src/router.tsx - Added trigger route
airflow-core/src/airflow/ui/src/pages/Dag/Dag.tsx - Added trigger tab
airflow-core/src/airflow/ui/src/pages/Dag/index.ts - Added Trigger export
airflow-core/src/airflow/ui/public/i18n/locales/en/dag.json - Added trigger translation

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 23, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@boring-cyborg boring-cyborg bot added area:translations area:UI Related to UI/UX. For Frontend Developers. translation:default labels Aug 23, 2025
@Thanush-03
Copy link
Author

@jscheffl
@shubhamraj-git
@pierrejeambrun
@bbovenzi
@ryanahamilton
kindly, provide review to my first pull request.

Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, this PR does not even build the software. It is also mis-understanding the UI concepts we already have.

I am not sure whether the code is generated by AI but in this way it can not be accepted.

Can you please re-work?

Target would be:

  • Trigger form is existing, it is about pre-populating values. Not another tab in the panel UI
  • Values should not need an encoded JSONbut as the ticket described a list of optional key=value pairs
  • The code compiles.

Please also add a screenshot or small video of how it looks for easier review.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add such MD files. This can go into the PR description. But we don't want to merge these file description to codebase.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

{ icon: <MdOutlineEventNote />, label: translate("tabs.auditLog"), value: "events" },
{ icon: <FiCode />, label: translate("tabs.code"), value: "code" },
{ icon: <MdDetails />, label: translate("tabs.details"), value: "details" },
{ icon: <FiPlay />, label: translate("tabs.trigger"), value: "trigger" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not the intend by this missing feature to add a new tab, The trigger form is opened as a modal already.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not add another form

Copy link
Member

@guan404ming guan404ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. But you may misunderstand what we need in this issue. You could take a look at this #54783 which try to finish similar task but in different form and also the FlexibleForm related component and functions. After that, I think you could understand how and what to do next. Feel free to ask anything!

@Thanush-03
Copy link
Author

sorry, i am beginner so i tried it,since it looks like a easy one.

@jscheffl
Copy link
Contributor

sorry, i am beginner so i tried it,since it looks like a easy one.

No worry, you can still make it. Or you pass the ball to @Thanush-03 who also opted-in for it. But also no pressure is not a critical feature and depending on individual pre-knowledge a simple task can be also complex for somebody else. All is included with some learning.

@Thanush-03
Copy link
Author

sir, can you provide the session details of this organisation was going in online so i can learn from that and also can you guide me

@jscheffl
Copy link
Contributor

sir, can you provide the session details of this organisation was going in online so i can learn from that and also can you guide me

I am not sure which organisation you mean? We have some contributing guides, for UI for example https://github.com/apache/airflow/blob/main/contributing-docs/15_node_environment_setup.rst but also worth reading the other docs.

@github-actions
Copy link

github-actions bot commented Oct 9, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 9, 2025
@github-actions github-actions bot closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:translations area:UI Related to UI/UX. For Frontend Developers. stale Stale PRs per the .github/workflows/stale.yml policy file translation:default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants