Add create_intermediate_dirs option to GCSToSFTPOperator
#54916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es should be created
boring-cyborg
bot
added
area:providers
provider:google
Contributor
VladaZakharova
left a comment
VladaZakharova
left a comment
There was a problem hiding this comment.
Hi there!
Thank you for PR, I have only one question:
Does this option cover cases when we have several folders as a tree of directories? like folder1/folder2/file.txt? will it create both folders if this parameters will be True?
Do we cover those cases in unit tests?
Collaborator
Author
|
@VladaZakharova - yes, these cases are covered by the rest of the unit-tests for this Operator. |
potiuk
approved these changes
Aug 26, 2025
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
…54916) * Adding create_intermediate_dirs to determine if intemediate directories should be created * Isolating tests for create_intermediate_dirs
nothingmin
pushed a commit
to nothingmin/airflow
that referenced
this pull request
Sep 2, 2025
…54916) * Adding create_intermediate_dirs to determine if intemediate directories should be created * Isolating tests for create_intermediate_dirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the behavior in the
SFTPOperator, thecreate_intermediate_dirsparameter was added to theGCSToSFTPOperator. If this isFalse, then the file will be copied/moved with running theSFTPHook.create_directory()method. An SFTP user may have permissions to copy/move a file, but not create a new directory. This resulted inPermissionError's. Per the original issue:closes: #54906