Skip to content

Fix kpo log_events_on_failure logs warnings at warning level #54967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romsharon98 merged 1 commit into from
Sep 7, 2025
Merged

Fix kpo log_events_on_failure logs warnings at warning level #54967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/operators/pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1088,10 +1088,11 @@ def _read_pod_events(self, pod, *, reraise=True) -> None:
"""Will fetch and emit events from pod."""
with _optionally_suppress(reraise=reraise):
for event in self.pod_manager.read_pod_events(pod).items:
if event.type == PodEventType.NORMAL.value:
self.log.info("Pod Event: %s - %s", event.reason, event.message)
if event.type == PodEventType.WARNING.value:
self.log.warning("Pod Event: %s - %s", event.reason, event.message)
else:
self.log.error("Pod Event: %s - %s", event.reason, event.message)
# events.k8s.io/v1 at this stage will always be Normal
self.log.info("Pod Event: %s - %s", event.reason, event.message)

def _read_pod_container_states(self, pod, *, reraise=True) -> None:
"""Log detailed container states of pod for debugging."""
Expand Down
4 changes: 2 additions & 2 deletions providers/cncf/kubernetes/tests/unit/cncf/kubernetes/operators/test_pod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2799,8 +2799,8 @@ def test_read_pod_events(mock_log, mock_pod_manager):
mock_event_normal.reason,
mock_event_normal.message,
)
# Assert that event with type `Warning` is logged as error.
mock_log.error.assert_called_once_with(
# Assert that event with type `Warning` is logged as warning.
mock_log.warning.assert_called_once_with(
"Pod Event: %s - %s",
mock_event_error.reason,
mock_event_error.message,
Expand Down