Skip to content

Conversation

@jscheffl
Copy link
Contributor

@jscheffl jscheffl commented Aug 27, 2025

Following #53563 this PR is the first round of "beautification".

Worker page:

  • Queues are as list
  • Status is using a colored badge
image

Jobs page:

  • Status is using a colored badge
image

@boring-cyborg boring-cyborg bot added area:dev-tools area:providers backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch kind:documentation provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Aug 27, 2025
@jscheffl jscheffl force-pushed the feature/add-state-badge-to-edge-react-ui branch from 0239cfb to a80b0e2 Compare September 3, 2025 13:05
@jscheffl jscheffl marked this pull request as ready for review September 3, 2025 13:05
@jscheffl jscheffl removed backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch area:dev-tools labels Sep 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements UI beautification for the Edge React interface by adding colored state badges and improving the display format for worker queues. The changes enhance the visual presentation of worker and job states to match Airflow 2's styling.

Key changes:

  • Replace plain text state displays with colored badges containing icons
  • Convert worker queues from string display to formatted list presentation
  • Create reusable badge components for both worker states and task instance states

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
providers/edge3/www-hash.txt Updates hash for frontend build changes
providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/WorkerPage.tsx Replaces plain text state with WorkerStateBadge and formats queues as list
providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/JobsPage.tsx Replaces plain text job state with StateBadge component
providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/WorkerStateIcon.tsx New component providing icons for different worker states
providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/WorkerStateBadge.tsx New badge component for worker states with color mapping
providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/StateIcon.tsx New component providing icons for task instance states
providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/StateBadge.tsx New badge component for task instance states

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jscheffl jscheffl force-pushed the feature/add-state-badge-to-edge-react-ui branch from a80b0e2 to 5d8fe8f Compare September 3, 2025 13:24
@jscheffl jscheffl force-pushed the feature/add-state-badge-to-edge-react-ui branch from 5d8fe8f to 297d324 Compare September 3, 2025 15:53
Copy link
Member

@dheerajturaga dheerajturaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this! it looks good!

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

@jscheffl jscheffl merged commit 48c824a into apache:main Sep 4, 2025
59 checks passed
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Sep 8, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
* Add colored status badge to Edge Worker react UI

* Remove outdated comment after eslint exception was removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers kind:documentation provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants