-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Feature/add state badge to edge react UI #54993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add state badge to edge react UI #54993
Conversation
0239cfb to
a80b0e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements UI beautification for the Edge React interface by adding colored state badges and improving the display format for worker queues. The changes enhance the visual presentation of worker and job states to match Airflow 2's styling.
Key changes:
- Replace plain text state displays with colored badges containing icons
- Convert worker queues from string display to formatted list presentation
- Create reusable badge components for both worker states and task instance states
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| providers/edge3/www-hash.txt | Updates hash for frontend build changes |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/WorkerPage.tsx | Replaces plain text state with WorkerStateBadge and formats queues as list |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/JobsPage.tsx | Replaces plain text job state with StateBadge component |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/WorkerStateIcon.tsx | New component providing icons for different worker states |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/WorkerStateBadge.tsx | New badge component for worker states with color mapping |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/StateIcon.tsx | New component providing icons for task instance states |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/StateBadge.tsx | New badge component for task instance states |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/StateIcon.tsx
Outdated
Show resolved
Hide resolved
providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/StateBadge.tsx
Show resolved
Hide resolved
a80b0e2 to
5d8fe8f
Compare
5d8fe8f to
297d324
Compare
dheerajturaga
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified this! it looks good!
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
* Add colored status badge to Edge Worker react UI * Remove outdated comment after eslint exception was removed
Following #53563 this PR is the first round of "beautification".
Worker page:
Jobs page: