-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add SQLInsertRowsOperator in common.sql provider #55031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
potiuk
merged 12 commits into
apache:main
from
dabla:feature/add-sql-insert-rows-operator
Aug 31, 2025
Merged
Add SQLInsertRowsOperator in common.sql provider #55031
potiuk
merged 12 commits into
apache:main
from
dabla:feature/add-sql-insert-rows-operator
Aug 31, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Tests failing :) |
potiuk
reviewed
Aug 30, 2025
Member
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just static check should be fixed.
potiuk
approved these changes
Aug 30, 2025
Contributor
Author
Fixed |
potiuk
approved these changes
Aug 31, 2025
nothingmin
pushed a commit
to nothingmin/airflow
that referenced
this pull request
Sep 2, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
* refactor: Added SQLInsertRowsOperator * docs: Added documentation for the SQLInsertRowsOperator * docs: Added example file for the SQLInsertRowsOperator * refactor: Fixed doc GenericTransfer: * refactor: Fixed static checks SQLInsertRowsOperator * refactor: Made conn_id optional in SQLInsertRowsOperator * refactor: Made rows optional in SQLInsertRowsOperator to fix PEP 484 issue * refactor: Removed duplicate blank line in SQLInsertRowsOperator docstring * refactor: Moved jinja to type checking block * refactor: Put summary on one line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already discussed previously on the devlist this PR adds the SQLInsertRowsOperator in the common sql provider. Main advantage of having such operators is that you don't need a PythonOperator or a task decorated python method in your DAG to allow inserting data from an XCom, you just call the operator, which allows you to keep your DAG clean and readable.
An example on how to use the operator:
It also offers some convienience methods like rows_processor, preoperator (like with GenericTransfer) and postoperator. It accepts the same parameters as the insert_rows method from the DbApiHook.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.