Skip to content

Use 'orient' kwarg in SalesforceHook #55056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
uranusjr merged 1 commit into from
Aug 29, 2025
Merged

Use 'orient' kwarg in SalesforceHook #55056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions providers/salesforce/src/airflow/providers/salesforce/hooks/salesforce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,9 +343,9 @@ def write_object_to_file(
# write the dataframe
df.to_csv(filename, index=False)
elif fmt == "json":
df.to_json(filename, "records", date_unit="s")
df.to_json(filename, orient="records", date_unit="s")
elif fmt == "ndjson":
df.to_json(filename, "records", lines=True, date_unit="s")
df.to_json(filename, orient="records", lines=True, date_unit="s")

return df

Expand Down
6 changes: 4 additions & 2 deletions providers/salesforce/tests/unit/salesforce/hooks/test_salesforce.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,9 @@ def test_write_object_to_file_json_with_timestamp_conversion(self, mock_data_fra
)

mock_describe_object.assert_called_once_with(obj_name)
mock_data_frame.return_value.to_json.assert_called_once_with(filename, "records", date_unit="s")
mock_data_frame.return_value.to_json.assert_called_once_with(
filename, orient="records", date_unit="s"
)
pd.testing.assert_frame_equal(
data_frame, pd.DataFrame({"test": [1, 2, 3], "field_1": [1.546301e09, 1.546387e09, 1.546474e09]})
)
Expand All @@ -396,7 +398,7 @@ def test_write_object_to_file_ndjson_with_record_time(self, mock_data_frame, moc
)

mock_data_frame.return_value.to_json.assert_called_once_with(
filename, "records", lines=True, date_unit="s"
filename, orient="records", lines=True, date_unit="s"
)
pd.testing.assert_frame_equal(
data_frame,
Expand Down
Loading