Skip to content

Conversation

@olegkachur-e
Copy link
Contributor

It allow propper work for operators that inherit from KubernetesPodOperator and override the invoke_defer method (GKE).


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues labels Aug 29, 2025
@olegkachur-e olegkachur-e force-pushed the fix_kubernetes_engine_async branch 2 times, most recently from faaed1b to bce8ffd Compare September 2, 2025 13:35
@olegkachur-e
Copy link
Contributor Author

Note: viewed internally by google-cloud-provider team.

@eladkal
Copy link
Contributor

eladkal commented Sep 2, 2025

Justification for this change?

@olegkachur-e
Copy link
Contributor Author

olegkachur-e commented Sep 3, 2025

Hi @eladkal,
Thank you for the review!

Justification for this change?

  • IMO moving this call, results in a bit cleaner code. Removing side effect from execute_async, and having convert_config_file_to_dict() in the method we actually use it's results.

  • Also, it allows proper methods override for inherited operators (GKEStartPodOperator), that don't have/need config file at all.

  • As there is visible improvements (to some extend) and no harm (to my best understanding), I consider it as win-win.

With that being said, I cautiously interpret changes as justified.

@olegkachur-e olegkachur-e force-pushed the fix_kubernetes_engine_async branch 8 times, most recently from 33f3b11 to ab7ce01 Compare September 10, 2025 12:43
@olegkachur-e olegkachur-e force-pushed the fix_kubernetes_engine_async branch from ab7ce01 to 8192583 Compare September 11, 2025 07:45
It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).
@olegkachur-e olegkachur-e force-pushed the fix_kubernetes_engine_async branch from 8192583 to 7b4952c Compare September 11, 2025 11:17
@VladaZakharova
Copy link
Contributor

hi @potiuk can you please check this PR? :)

@potiuk potiuk merged commit 2de2687 into apache:main Sep 12, 2025
86 checks passed
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
…ache#55064)

It allow propper work for operators that inherit from
KubernetesPodOperator and override the invoke_defer method (GKE).

Co-authored-by: Oleg Kachur <kachur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:cncf-kubernetes Kubernetes (k8s) provider related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants