-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Fix: use merged headers in LivyAsyncHook API call #55072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
|
Sorry, I'm having some problems with running the unit tests locally. Trying to fix it now. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
|
@eladkal when can we expect the next PyPi release? |
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
We are running vote currently for next vote and it was not merged before: #55285 so it will be in the next one. We usually (but not guaranteed) release providers in some 2-week-ish cadence. But you are absolutely not blocked until it happens. You can easily monkeypatch or extend the classes modified in this PR, also if you want to you can easily build and install livy provider from main (also that would be a good test: breeze release-management prepare-provider-distributions apache.livy |
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
* Fix: use merged headers in LivyAsyncHook API call * Fix: pass extra headers in LivyAsyncHook API call * Test: get batch state with extra headers * Test: get batch state with extra headers * Fix: pass extra headers in get batch logs * Fix: pass extra headers in get batch logs --------- Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
Hello! This is my first OS PR :)
This bug prevented from using the Livy operator with deferrable enabled and passing extra headers, in my case, an authentication Bearer token.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.