Skip to content

Conversation

@javierherrer
Copy link
Contributor

Hello! This is my first OS PR :)

This bug prevented from using the Livy operator with deferrable enabled and passing extra headers, in my case, an authentication Bearer token.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 29, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@eladkal eladkal requested review from Lee-W and romsharon98 September 3, 2025 09:44
@javierherrer
Copy link
Contributor Author

Sorry, I'm having some problems with running the unit tests locally. Trying to fix it now.

@javierherrer
Copy link
Contributor Author

@eladkal @Lee-W please let me know if it looks good to you now :)

@potiuk potiuk merged commit 3a2a13f into apache:main Sep 6, 2025
73 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 6, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Sep 7, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
@javierherrer
Copy link
Contributor Author

@eladkal when can we expect the next PyPi release?

RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Sep 8, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
@potiuk
Copy link
Member

potiuk commented Sep 9, 2025

@eladkal when can we expect the next PyPi release?

We are running vote currently for next vote and it was not merged before: #55285 so it will be in the next one. We usually (but not guaranteed) release providers in some 2-week-ish cadence. But you are absolutely not blocked until it happens. You can easily monkeypatch or extend the classes modified in this PR, also if you want to you can easily build and install livy provider from main (also that would be a good test:

breeze release-management prepare-provider-distributions apache.livy

abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
* Fix: use merged headers in LivyAsyncHook API call

* Fix: pass extra headers in LivyAsyncHook API call

* Test: get batch state with extra headers

* Test: get batch state with extra headers

* Fix: pass extra headers in get batch logs

* Fix: pass extra headers in get batch logs

---------

Co-authored-by: Javier Herrer Torres <javierhe@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants