Revert "Support templated extra in outlets assets (#54885)" #55199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
approved these changes
Sep 3, 2025
Member
|
These two interface looks almost the same. Should we remove or rename one of them to avoid this kind of misunderstanding? I think AssetEvent extra is more useful than the asset one but asset extra also might have some use cases |
vatsrahul1001
approved these changes
Sep 3, 2025
Member
Author
|
See #55200 for a proposal to improve the situation. |
kaxil
approved these changes
Sep 3, 2025
This reverts commit 438b76c.
uranusjr
force-pushed
the
revert-asset-extra-template
branch
from
0c01f7f to
f209fb5
Compare
hussein-awala
approved these changes
Sep 4, 2025
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
I’m fine with this.
Would you like to implement your suggestion before version 3.1.0, or should I take care of it?
RoyLee1224
pushed a commit
to RoyLee1224/airflow
that referenced
this pull request
Sep 8, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
…ache#55199) This reverts commit 438b76c.
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
…ache#55199) This reverts commit 438b76c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #54885. The PR should not have gone in. Asset extras and asset event extras are different entities, and NOT DESIGNED TO BE MERGED.
https://airflow.apache.org/docs/apache-airflow/stable/authoring-and-scheduling/assets.html#attaching-extra-information-to-an-emitting-asset-event
This is an explicit design. It can be changed, but should not be done in a simple PR.