Skip to content

Conversation

@shahar1
Copy link
Contributor

@shahar1 shahar1 commented Sep 6, 2025

related: #55316

cc: @morgan-dgk


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Sep 6, 2025
@shahar1 shahar1 changed the title Fix unit tests of Cloud RUn Async hook Fix unit tests of Cloud Run Async hook Sep 6, 2025
@shahar1 shahar1 changed the title Fix unit tests of Cloud Run Async hook Fix unit tests of Cloud Run async hook Sep 6, 2025
@shahar1 shahar1 requested review from eladkal and potiuk September 6, 2025 09:47
@shahar1 shahar1 force-pushed the fix-cloud-run-async-hook-ut branch from 8492ecb to ef8264c Compare September 6, 2025 10:15
@shahar1 shahar1 changed the title Fix unit tests of Cloud Run async hook Fix sync_hook_class and unit tests of Cloud Run async hook Sep 6, 2025
@potiuk
Copy link
Member

potiuk commented Sep 6, 2025

Hmm. Does not seem to fix things :(

@shahar1
Copy link
Contributor Author

shahar1 commented Sep 6, 2025

Hmm. Does not seem to fix things :(

Just realized I might have introduced other issues as I fixed tests of another hook in the same file (which basically needs the same treatment as the original).
I'll fix both and merge after it's all green :D

@shahar1 shahar1 force-pushed the fix-cloud-run-async-hook-ut branch from ef8264c to 77abc28 Compare September 6, 2025 10:56
@shahar1 shahar1 changed the title Fix sync_hook_class and unit tests of Cloud Run async hook Fix Cloud Run async hooks (inc. unit tests) Sep 6, 2025
@shahar1 shahar1 force-pushed the fix-cloud-run-async-hook-ut branch 4 times, most recently from 5215741 to f9f5b72 Compare September 6, 2025 14:13
@shahar1 shahar1 force-pushed the fix-cloud-run-async-hook-ut branch from f9f5b72 to 42f3eef Compare September 6, 2025 14:19
@potiuk potiuk merged commit 75443e4 into apache:main Sep 6, 2025
77 checks passed
@shahar1 shahar1 deleted the fix-cloud-run-async-hook-ut branch September 6, 2025 14:53
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Sep 7, 2025
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Sep 8, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants