-
Notifications
You must be signed in to change notification settings - Fork 16.3k
Add Links to Edge React UI #55356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Links to Edge React UI #55356
Conversation
|
@jscheffl, I tested this. Couple of observations.
|
The jobs are vanishing after completion, the time is configurable - individually for failed and success, see: https://airflow.apache.org/docs/apache-airflow-providers-edge3/stable/configurations-ref.html#job-success-purge
Pushed an update to disable "live updates", then the time is only calculated on page refresh. Still in seconds - is this OK? Or do you think a string |
23021a9 to
1b0695a
Compare
Yup! This looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the React UI for the Edge Provider by adding navigation links, relative timestamps, and improved tooltips to improve user experience and navigation.
- Adds clickable links from jobs to DAG pages and from workers to job details
- Replaces absolute timestamps with relative "time ago" format using react-timeago
- Enhances worker state badges with descriptive tooltips and adds scroll-to-anchor functionality
Reviewed Changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| providers/edge3/www-hash.txt | Updates the hash for the built web assets |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/WorkerPage.tsx | Adds TimeAgo components for timestamps and scroll-to-anchor functionality |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/pages/JobsPage.tsx | Adds navigation links to DAGs/tasks and TimeAgo components for timestamps |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/ui/index.ts | Exports the new ScrollToAnchor component |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/ui/ScrollToAnchor.tsx | New component for handling URL hash navigation |
| providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/WorkerStateBadge.tsx | Adds tooltips with state descriptions |
| providers/edge3/src/airflow/providers/edge3/plugins/www/package.json | Adds react-timeago dependency and other packages |
Files not reviewed (1)
- providers/edge3/src/airflow/providers/edge3/plugins/www/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
providers/edge3/src/airflow/providers/edge3/plugins/www/package.json
Outdated
Show resolved
Hide resolved
providers/edge3/src/airflow/providers/edge3/plugins/www/package.json
Outdated
Show resolved
Hide resolved
providers/edge3/src/airflow/providers/edge3/plugins/www/src/components/ui/ScrollToAnchor.tsx
Outdated
Show resolved
Hide resolved
02c8356 to
1d9b738
Compare
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback
* Add Links to Edge React UI * Turn off live updates for time-ago * Copilot feedback



Some (next) level of beautification to React UI of Edge Provider:
@pierrejeambrun / @shubhamraj-git / @bbovenzi I attempted to use
<Link to=...>from react-router-dom but seems this is only working inside the plugin but links to core UI generate blank pages. Is there a security barrier I need to break or how can I make internal links working from the plugin? Security barrier? Needed to switch to the<Link href=...from React which is always making a full page reload which is un-cool.FYI @dheerajturaga