Add confirmation dialog for exit maintenance action in Edge Worker Page #55400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:edge
jscheffl
reviewed
Sep 9, 2025
Contributor
jscheffl
left a comment
jscheffl
left a comment
There was a problem hiding this comment.
Cool! This would have been my next as well but you were faster. Good that you added the button, I think this was also missing before.
...iders/edge3/src/airflow/providers/edge3/plugins/www/src/components/MaintenanceExitButton.tsx
Outdated
Show resolved
Hide resolved
...iders/edge3/src/airflow/providers/edge3/plugins/www/src/components/MaintenanceExitButton.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Sorry, now I merged a feature and a re-creation of compiled code is needed :-( |
jscheffl
approved these changes
Sep 10, 2025
dheerajturaga
force-pushed
the
feature/edge-exit-confirmation
branch
from
3d2fe34 to
a4f856e
Compare
Member
Author
No worries I rebased and recompiled them |
- Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode
- Added Yes/No confirmation similar to enter maintenance flow
- Prevents accidental exit from maintenance mode for edge workers
- Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}?
dheerajturaga
force-pushed
the
feature/edge-exit-confirmation
branch
from
a4f856e to
a4797c8
Compare
jscheffl
approved these changes
Sep 11, 2025
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
Brunda10
pushed a commit
to Brunda10/airflow
that referenced
this pull request
Sep 17, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
78 tasks
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
…ge (apache#55400) * Add confirmation dialog for exit maintenance action in Edge Worker Page - Modified MaintenanceExitButton component to show confirmation dialog before exiting maintenance mode - Added Yes/No confirmation similar to enter maintenance flow - Prevents accidental exit from maintenance mode for edge workers - Dialog asks "Are you sure you want to exit maintenance mode for worker {workerName}? * Jens suggestions * Remove exit maintenance color scheme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @jscheffl