-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling #55455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling #55455
Conversation
|
@AutomationDev85 are there further (Non WASB) Log handlers in the repo which have the same problem? Can you double check? |
|
@jscheffl Good point. I added also the change for OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler |
…, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling
dd3c08a to
ca638a6
Compare
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extension to other task handlers. Looks good in my view.
For LGTM but would wait 1-2-3 days if zthere is another reviewer available prior merge with a second opinion. In my view really good to make it generically available.
|
Is this change backward compatible with Airflow 2.10? I am not sure what Airflow version introduced these parameters |
Yes, the additional parameters were introduced in Airflow 2.10. See #41064 |
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455) * WasbTaskHandler supports log file size handling * OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling * Remove space --------- Co-authored-by: AutomationDev85 <AutomationDev85>
Overview
We faced an issue that some workloads created huge log files which was filling up our log space. We are using the WasbTaskHandler and as the FileTaskHandler supports the max_bytes feature of the NonCachingRotatingFileHandler we would like to enable the WasbTaskHandler to support the same feature as the FileTaskHandler. With this PR it is possible to set the same parameters to limit the log file size.
Details of change: