Skip to content

Conversation

@AutomationDev85
Copy link
Contributor

Overview

We faced an issue that some workloads created huge log files which was filling up our log space. We are using the WasbTaskHandler and as the FileTaskHandler supports the max_bytes feature of the NonCachingRotatingFileHandler we would like to enable the WasbTaskHandler to support the same feature as the FileTaskHandler. With this PR it is possible to set the same parameters to limit the log file size.

Details of change:

  • WasbTaskHandler calls constructor of FileTaskHandler with parameters to support the log file size limit.

@jscheffl
Copy link
Contributor

@AutomationDev85 are there further (Non WASB) Log handlers in the repo which have the same problem? Can you double check?

@AutomationDev85
Copy link
Contributor Author

@jscheffl Good point. I added also the change for OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler

@AutomationDev85 AutomationDev85 changed the title [providers-microsoft-azure][WasbTaskHandler] supports log file size handling [OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling Sep 10, 2025
…, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling
@AutomationDev85 AutomationDev85 force-pushed the feature/enable-wasbtaskhandler-to-support-log-file-size branch from dd3c08a to ca638a6 Compare September 10, 2025 13:41
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extension to other task handlers. Looks good in my view.

For LGTM but would wait 1-2-3 days if zthere is another reviewer available prior merge with a second opinion. In my view really good to make it generically available.

@eladkal
Copy link
Contributor

eladkal commented Sep 14, 2025

Is this change backward compatible with Airflow 2.10? I am not sure what Airflow version introduced these parameters

@jscheffl
Copy link
Contributor

Is this change backward compatible with Airflow 2.10? I am not sure what Airflow version introduced these parameters

Yes, the additional parameters were introduced in Airflow 2.10. See #41064
As we dropped Airflow 2.9 support in Providers this is not breaking compatibility.

@jscheffl jscheffl merged commit 0cb97db into apache:main Sep 14, 2025
77 checks passed
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
…r, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler, WasbTaskHandler] supports log file size handling (apache#55455)

* WasbTaskHandler supports log file size handling

* OSSTaskHandler, CloudwatchTaskHandler, S3TaskHandler, HdfsTaskHandler, ElasticsearchTaskHandler, GCSTaskHandler, OpensearchTaskHandler, RedisTaskHandler support log file size handling

* Remove space

---------

Co-authored-by: AutomationDev85 <AutomationDev85>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants