-
Notifications
You must be signed in to change notification settings - Fork 16.4k
Add CI job to test airflow standalone startup #55458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
48d3d3d to
0c4f14e
Compare
|
Right, I seem to have it run as I expect it to |
ashb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How long does this take to run? I can't recall off the top of my head when the basic tests workflow is run, but is this perhaps going to run too often or to early?
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Do we also jneed to adjust selective checks or would this run only in canary?
|
@jscheffl its not just the scheduler, its runs there and in the PR too |
potiuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. One nit -> I think with cat we will show the log twice if it fails - once when running and second time when it fails.
Yep. Not a big overhead at all. |
Its probably good to show it while running due to the |
gopidesupavan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice:)
|
No need to backport this |

Why?
Yesterday while trying to release beta1 for 3.1, @kaxil ran into this error: #55443. This was an issue where none of the "airflow cli" commands worked, the impact of this is that new users would probably struggle to onboard.
What?
Adding a CI job that can run "airflow standalone". This job validates that the airflow standalone command can start successfully without hanging or crashing, providing early detection of critical startup issues in the basic CI workflow.
Exit criteria:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.