fix: Adding two required arguments on BigQuery hook create_table

[FVidalCarneiro]

Adding two required arguments on BigQuery hook create_table method, that were not there before. This is the solution to a bug.

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
• Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: dev@airflow.apache.org
  Slack: https://s.apache.org/airflow-slack

[jroachgolf84]

@FVidalCarneiro, looks good! Does it make sense to try and add a test? Maybe not, but thought I'd check.

[FVidalCarneiro]

@FVidalCarneiro, looks good! Does it make sense to try and add a test? Maybe not, but thought I'd check.

Hello @jroachgolf84 , I guess we could add one to airflow/providers/google/tests/unit/google/cloud/operators but I didn’t since there wasn’t any file dedicated for this operator. Likewise, this is my first contribution so I'm not very familiar with the pattern to make tests.

[kev-datams]

Hi,

Perhaps @Crowiant who introduced the original breaking change is more familiar with tests to create a new one ?

Thank you all :)

[gopidesupavan]

Needs tests for this.

please look at here -> unit/google/cloud/transfers/test_gcs_to_bigquery.py

[VladaZakharova]

hi
please also share the screenshot of the system tests for bigquery operators
unit tests will be also good to see from the person who introduced the changes :)

[FVidalCarneiro]

There are plenty of tests already available in the test file, I noticed the test_external_table_should_accept_orc_source_format method should have failed if it was setup correctly. Anyone familiar with the testing framework in airflow could give me a hand to check if it is indeed called?

I also agree that the original contributor that introduced the breaking change is better placed than I to introduce the test :)

[jroachgolf84]

@FVidalCarneiro - reach out to me in the Airflow OSS Slack, and we can talk about what writing unit tests would look like for this PR. This is a good opportunity for you!

[github-actions]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

[kev-datams]

Still open issue, who could add expected tests please ?

[potiuk]

Still open issue, who could add expected tests please ?

Maybe you @kev-datams ? Take over the PR, open yours and add tests. This is how open source works, usually those who need things most are the most likely to contribute them.

[kev-datams]

Still open issue, who could add expected tests please ?

Maybe you @kev-datams ? Take over the PR, open yours and add tests. This is how open source works, usually those who need things most are the most likely to contribute them.

Agree, but no time for it currently unfortunately.

[nathadfield]

I'll pick this and submit a new PR containing the fix and tests.

[nathadfield]

New PR with updated tests.