Fix error when retrieving logs of ti not run because of upstream failures #55517
+17
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecause of upstream failures
Contributor
ephraimbuddy
left a comment
ephraimbuddy
left a comment
There was a problem hiding this comment.
LGTM. Just a little clarification on the test
Contributor
Author
|
@ephraimbuddy, are those clarifications enough? |
ephraimbuddy
approved these changes
Sep 16, 2025
suman-himanshu
pushed a commit
to suman-himanshu/airflow
that referenced
this pull request
Sep 17, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
…ures (apache#55517) * Fix TestFileTaskLogHandler tests * Return placeholder message when requested the logs of tasks skipped because of upstream failures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return placeholder message when requested the logs of tasks skipped because of upstream failures as we were doing previously for skipped tis.
Before updating the test for the fix, enable the tests in
TestFileTaskLogHandlerand fix them.closes: #55514
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.