Skip to content

Conversation

@gopidesupavan
Copy link
Member

Seems triggers are blocking, https://github.com/apache/airflow/actions/runs/17663772440/job/50205537877#step:8:3237

Reduce poke interval and lets delete the triggers created after the assertion. this is just an attempt to fix.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@potiuk potiuk merged commit 11f8cc3 into apache:main Sep 12, 2025
59 checks passed
@potiuk
Copy link
Member

potiuk commented Sep 12, 2025

Cool! Let's see if it helps :)

@tirkarthi
Copy link
Contributor

Thanks @gopidesupavan . The log is displayed after 60 seconds which was hard-coded in the code. I had to mock time.monotonic for testing but it also affected asyncio which also used time.monotonic internally. I made the mock to return values in increments of 60 for the log to appear quickly. I am not sure if this is also causing issues but wanted to add it here.

@gopidesupavan gopidesupavan deleted the fix-trigger-job-tests branch September 12, 2025 19:31
@gopidesupavan
Copy link
Member Author

Thanks @gopidesupavan . The log is displayed after 60 seconds which was hard-coded in the code. I had to mock time.monotonic for testing but it also affected asyncio which also used time.monotonic internally. I made the mock to return values in increments of 60 for the log to appear quickly. I am not sure if this is also causing issues but wanted to add it here.

yeah lets see if this fixes or not will take a look later :)

suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
gopidesupavan added a commit to gopidesupavan/airflow that referenced this pull request Sep 17, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
kaxil pushed a commit that referenced this pull request Sep 17, 2025
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Sep 30, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 1, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 2, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 3, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 4, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 5, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 7, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 8, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 9, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 10, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 11, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 12, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 14, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 15, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 17, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
abdulrahman305 bot pushed a commit to abdulrahman305/airflow that referenced this pull request Oct 19, 2025
* Fix trigger log tests

* Fix trigger job log test

* Resolve comments
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 24, 2025
cherry-picked 11f8cc3

apache/airflow#55563

GitOrigin-RevId: 063a0e33cbaab0296a29adcf4dc0e5d5da98eb15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants