Skip to content

Conversation

@jscheffl
Copy link
Contributor

There is a teething problem that the Chakra "Toast" component is not working in Edge React UI. I need some React Expertise to fix it seems.

@shubhamraj-git / @bbovenzi / @pierrejeambrun HELP :-D

To make this reprodicible I made two toasters:
1 in the Navbar and one in te Edge UI plugin.

How to see the error:

  1. Take this branch
  2. Run it locally via breeze start-airflow --python 3.12 --backend postgres --executor EdgeExecutor --load-example-dags
  3. Open the Web UI and after login on the start page, click on the "Toast" button in the Navbar - all OK
  4. Navifate to "Admin" -> "Edge Worker Hosts" (Which is the React Plugin)
  5. Click the same button --> Does not respond. See JavaScript console that logs are written and no errors
  6. Attempt to click on the Toaster Test button in the Plugin itself, also not working
  7. Same if you use the IFrame plugin in "Docs" -> "Edge API Docs", also there the Toaster in Navbar is not working

Is this a limitation of the plugin concept or a bug in my Plugin? How can the Toaster be made working?

@boring-cyborg boring-cyborg bot added area:providers area:UI Related to UI/UX. For Frontend Developers. provider:edge Edge Executor / Worker (AIP-69) / edge3 labels Sep 13, 2025
@jscheffl jscheffl force-pushed the bugfix/fix-toaster-in-plugin branch from 0e30e30 to 104551a Compare September 14, 2025 20:44
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 30, 2025
@pierrejeambrun
Copy link
Member

Up

@pierrejeambrun pierrejeambrun removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 30, 2025
@jscheffl jscheffl force-pushed the bugfix/fix-toaster-in-plugin branch from 104551a to 770c74f Compare November 11, 2025 20:19
@jscheffl
Copy link
Contributor Author

up for ~1200 commits :-D

@jscheffl jscheffl force-pushed the bugfix/fix-toaster-in-plugin branch from 770c74f to f976a86 Compare December 23, 2025 18:07
@jscheffl
Copy link
Contributor Author

up for ~720 commits :-D (again)

@jscheffl
Copy link
Contributor Author

@pierrejeambrun Interesting, still do not understand the root cause why a toaster is not working on Plugins pages but what I noticed in the browser is that there is a <div> element rendered for all pages which seems to hold the toaster below the root div element with the id="toast-group":
image

This one is missing on the Plugins page - and don't know if this helps in trigaing - but noticed when navigating to Admin -> Configs (url: /config) which is raising a forbidden error via HTTP 403, there also the toaster is not working with the explicit ybutton in the Nav.

Copy link
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have to investigate. But my guess is that Chakra UI handles the toaster via 'portals' into a specific unique dom element that is global. So basically any toaster will render in that shared toast-group element.

Then there might be some sort of conflict, the plugin toast can't find the proper host element to portal the toast to.

I'm sorry for the delay and not finding time to look at this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers area:UI Related to UI/UX. For Frontend Developers. provider:edge Edge Executor / Worker (AIP-69) / edge3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants