-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[DO NOT MERGE] Attempt to fix Toaster in Plugin #55641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0e30e30 to
104551a
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
Up |
104551a to
770c74f
Compare
|
up for ~1200 commits :-D |
770c74f to
f976a86
Compare
|
up for ~720 commits :-D (again) |
|
@pierrejeambrun Interesting, still do not understand the root cause why a toaster is not working on Plugins pages but what I noticed in the browser is that there is a This one is missing on the Plugins page - and don't know if this helps in trigaing - but noticed when navigating to Admin -> Configs (url: |
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have to investigate. But my guess is that Chakra UI handles the toaster via 'portals' into a specific unique dom element that is global. So basically any toaster will render in that shared toast-group element.
Then there might be some sort of conflict, the plugin toast can't find the proper host element to portal the toast to.
I'm sorry for the delay and not finding time to look at this yet.

There is a teething problem that the Chakra "Toast" component is not working in Edge React UI. I need some React Expertise to fix it seems.
@shubhamraj-git / @bbovenzi / @pierrejeambrun HELP :-D
To make this reprodicible I made two toasters:
1 in the Navbar and one in te Edge UI plugin.
How to see the error:
breeze start-airflow --python 3.12 --backend postgres --executor EdgeExecutor --load-example-dagsIs this a limitation of the plugin concept or a bug in my Plugin? How can the Toaster be made working?