-
Notifications
You must be signed in to change notification settings - Fork 16.4k
UI: switch DAG Run → Task Instances tab to FilterBar (pill UI) #55650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Kavya Katal <kavyakatal09@gmail.com>
|
This PR currently modifies the Task Instances view (all TIs), which isn't ready for the FilterBar yet (#53042) The view that we actually need to update is the Tasks tab(inside a specific DAG), which is covered in #54484. You can see the correct page by clicking into any DAG and then selecting the 'Tasks' tab.
|
bbovenzi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 for now.
There's no point in using the filtar bar for a single search input.
We do need to add more filters to the Task Instances table. Also, our FilterBar needs to integrate select and multiselect components, which we need for the tasks view too.
Even if we're going to remove TasklnstancesFilter then we need to delete the file too.
|
@bbovenzi Thanks for the review , I will try to implement a pill based filter bar which allows to select multiple filter pills for same type as well as others and will delete the old TaskInstancesFile file once my changes feel good. Please let me know if i am on correct path of thinking or Please add if i am missing something. |
|
It's not worth it for the TaskInstances table yet, but as Roy Lee pointed out. It is worth it for the Tasks table. But please make sure to manually test it, the user interactions like when to add or remove focus on the select dropdown is trickier than simple text/number/date inputs. This is something that an AI tool isn't great at. |
|
Gonna close this PR. If you want to work on a new Filter Pill and then use it for the tasks page. Then it should be a different PR. |
|
@bbovenzi I really think i can pull this off with proper manual testing and check in UI after implementation, i would really like to give it a try , Please suggest if i should create a new issue and raise PR or raise it in current issue only. |
|
Yes, just open a different PR when you're ready |
|
@KatalKavya96 @bbovenzi I’ve implemented the select dropdown filter in #55620, please take another look, thanks! |

Why
Standardise on the new pill-based FilterBar to reduce vertical space and match XCom/Events UX.
Keep URL ↔ UI sync so filters are shareable/deeplinkable.
What
Replace the legacy filters on DAG Run → Task Instances with the reusable FilterBar.
New component: RunTaskFilters.tsx (text + date pills).
URL parameters handled via useFiltersHandler:
name_pattern → passed to API as taskDisplayNamePattern
start_date / end_date → mapped to API’s start_date_gte / end_date_lte
No backend/API changes, no translation surface area changes.
Scope
Only the Task Instances tab under a DAG Run.
Other DAG Run sub-pages will be migrated in next commits
Testing**
pnpm run lint + tsc --noEmit pass locally.
Manual in Breeze:
Network shows:
/api/v2/dags/
/dagRuns//taskInstances?task_display_name_pattern=cli_…4.Remove pills or click Reset → URL/query clears and results reset.
Backward compatibility
Preserves existing date query keys; adds name_pattern for task display name search.
No UI breaking changes; the table and actions are unchanged.
Screenshots
related: #55520