Skip to content

Conversation

@KatalKavya96
Copy link
Contributor

Why

  • Standardise on the new pill-based FilterBar to reduce vertical space and match XCom/Events UX.

  • Keep URL ↔ UI sync so filters are shareable/deeplinkable.

What

  • Replace the legacy filters on DAG Run → Task Instances with the reusable FilterBar.

  • New component: RunTaskFilters.tsx (text + date pills).

  • URL parameters handled via useFiltersHandler:

  • name_pattern → passed to API as taskDisplayNamePattern

  • start_date / end_date → mapped to API’s start_date_gte / end_date_lte

  • No backend/API changes, no translation surface area changes.

Scope

  • Only the Task Instances tab under a DAG Run.

  • Other DAG Run sub-pages will be migrated in next commits

Testing**

  • pnpm run lint + tsc --noEmit pass locally.

  • Manual in Breeze:

  1. Go to a DAG Run → Tasks tab.
  2. Click + Filter → add Task Name; type cli_.

Network shows:
/api/v2/dags//dagRuns//taskInstances?task_display_name_pattern=cli_…

  1. Add From/To pills; network includes start_date_gte / end_date_lte.

4.Remove pills or click Reset → URL/query clears and results reset.

Backward compatibility

  • Preserves existing date query keys; adds name_pattern for task display name search.

  • No UI breaking changes; the table and actions are unchanged.

Screenshots

Screenshot 2025-09-15 at 1 26 28 AM Screenshot 2025-09-15 at 1 26 36 AM

related: #55520

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Sep 14, 2025
Signed-off-by: Kavya Katal <kavyakatal09@gmail.com>
@RoyLee1224
Copy link
Contributor

RoyLee1224 commented Sep 15, 2025

This PR currently modifies the Task Instances view (all TIs), which isn't ready for the FilterBar yet (#53042)

The view that we actually need to update is the Tasks tab(inside a specific DAG), which is covered in #54484. You can see the correct page by clicking into any DAG and then selecting the 'Tasks' tab.

CleanShot 2025-09-15 at 09 12 56

Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 for now.

There's no point in using the filtar bar for a single search input.

We do need to add more filters to the Task Instances table. Also, our FilterBar needs to integrate select and multiselect components, which we need for the tasks view too.

Even if we're going to remove TasklnstancesFilter then we need to delete the file too.

@KatalKavya96
Copy link
Contributor Author

@bbovenzi Thanks for the review , I will try to implement a pill based filter bar which allows to select multiple filter pills for same type as well as others and will delete the old TaskInstancesFile file once my changes feel good. Please let me know if i am on correct path of thinking or Please add if i am missing something.

@bbovenzi
Copy link
Contributor

It's not worth it for the TaskInstances table yet, but as Roy Lee pointed out. It is worth it for the Tasks table. But please make sure to manually test it, the user interactions like when to add or remove focus on the select dropdown is trickier than simple text/number/date inputs. This is something that an AI tool isn't great at.

@bbovenzi
Copy link
Contributor

Gonna close this PR. If you want to work on a new Filter Pill and then use it for the tasks page. Then it should be a different PR.

@bbovenzi bbovenzi closed this Sep 15, 2025
@KatalKavya96
Copy link
Contributor Author

@bbovenzi I really think i can pull this off with proper manual testing and check in UI after implementation, i would really like to give it a try , Please suggest if i should create a new issue and raise PR or raise it in current issue only.

@bbovenzi
Copy link
Contributor

Yes, just open a different PR when you're ready

@guan404ming
Copy link
Member

@KatalKavya96 @bbovenzi I’ve implemented the select dropdown filter in #55620, please take another look, thanks!

@KatalKavya96 KatalKavya96 deleted the feat/ui-dagrun-filterbar branch September 15, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants