Implement filter_authorized_connections, filter_authorized_pools and filter_authorized_variables in AWS auth manager
#55687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and `filter_authorized_variables` in AWS auth manager
ferruzzi
approved these changes
Sep 19, 2025
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Feels like filter_authorized_{foo} methods could be consolidated into a generic "filter list" method, but I don't have the whole plan/picture here so maybe that's not worth the effort.
Code LGTM
Contributor
Author
You're right but we might want to keep it because when it might make our life easier when we will "teamify" AWS auth manager. If not, we could indeed factorize the code a bit. Let's wait and see :) |
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Sep 30, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 1, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
10 tasks
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 2, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 3, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 4, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 5, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 7, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 8, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 9, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 10, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 11, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 12, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 14, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 15, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 17, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
abdulrahman305 bot
pushed a commit
to abdulrahman305/airflow
that referenced
this pull request
Oct 19, 2025
…and `filter_authorized_variables` in AWS auth manager (apache#55687)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement these methods to leverage batch APIs from Amazon Verified Permissions. Follow-up of #55298.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.